Re: [PATCH v3 35/35] remote-curl: don't request v2 when pushing

From: Jonathan Tan <jonathantanmy@google.com>
Date: Feb 22, 2018, 00:12 UTC
Message-ID: <20180221161209.80f0a3b941a069ea78ccf43e@google.com>
In-Reply-To: <20180207011312.189834-36-bmwill@google.com>

On Tue, 6 Feb 2018 17:13:12 -0800 Brandon Williams <bmwill@google.com> wrote:

Show 11 quoted lines

> +test_expect_success 'push with http:// and a config of v2 does not request v2' '
> +	# Till v2 for push is designed, make sure that if a client has
> +	# protocol.version configured to use v2, that the client instead falls
> +	# back and uses v0.
> +
> +	test_commit -C http_child three &&
> +
> +	# Push to another branch, as the target repository has the
> +	# master branch checked out and we cannot push into it.
> +	GIT_TRACE_PACKET=1 git -C http_child -c protocol.version=1 \
> +		push origin HEAD:client_branch && 2>log &&

Should it be protocol.version=2? Also, two double ampersands?

Also, optionally, it might be better to do GIT_TRACE_PACKET="$(pwd)/log", so that it does not get mixed with other stderr output.