Re: [PATCH v3 03/35] pkt-line: add delim packet support
- From
- Brandon Williams <bmwill@google.com>
- Date
- Feb 22, 2018, 19:37 UTC
- Message-ID
- <20180222193708.GM185096@google.com>
- In-Reply-To
- <CAGZ79kauYniFpo+Y_hFauVKMWNgxjQ_OOoX0mgePcr3Z6hSLWg@mail.gmail.com>
On 02/22, Stefan Beller wrote:
Show 14 quoted lines
> On Tue, Feb 6, 2018 at 5:12 PM, Brandon Williams <bmwill@google.com> wrote: > > One of the design goals of protocol-v2 is to improve the semantics of > > flush packets. Currently in protocol-v1, flush packets are used both to > > indicate a break in a list of packet lines as well as an indication that > > one side has finished speaking. This makes it particularly difficult > > to implement proxies as a proxy would need to completely understand git > > protocol instead of simply looking for a flush packet. > > > > To do this, introduce the special deliminator packet '0001'. A delim > > packet can then be used as a deliminator between lists of packet lines > > while flush packets can be reserved to indicate the end of a response. > > Please mention where this can be found in the documentation. > (Defer to later patch?)
Yeah the documentation does get added in a future patch, I'll make a comment to that effect.
Show 8 quoted lines
> As the commit message states, this is only to be used for v2, > in v0 it is still an illegal pkt. > > > > > Signed-off-by: Brandon Williams <bmwill@google.com> > > The code is > Reviewed-by: Stefan Beller <sbeller@google.com>
-- Brandon Williams