Re: [PATCH v3 04/35] upload-pack: convert to a builtin

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 12, 2018, 22:43 UTC
Message-ID: <20180312224355.GC58506@aiede.svl.corp.google.com>
In-Reply-To: <20180222214457.GB30638@sigill.intra.peff.net>

Hi,

Jeff King wrote:

> On Thu, Feb 22, 2018 at 01:26:34PM -0800, Jonathan Nieder wrote:

Show 6 quoted lines

>> Keep in mind that git upload-archive (a read-only command, just like
>> git upload-pack) also already has the same issues.
>
> Yuck. I don't think we've ever made a historical promise about that. But
> then, I don't think the promise about upload-pack has ever really been
> documented, except in mailing list discussions.

Sorry to revive this old side-thread. Good news: for a dashed command like git-upload-archive, the pager selection code only runs for commands with RUN_SETUP or RUN_SETUP_GENTLY:

	if (use_pager == -1 && p->option & (RUN_SETUP | RUN_SETUP_GENTLY) &&
	    !(p->option & DELAY_PAGER_CONFIG))
		use_pager = check_pager_config(p->cmd);

None of upload-pack, receive-pack,git-serve, or upload-archive set those flags, so we (narrowly) escape trouble here.

Later today I should be able to send a cleanup to make the behavior more obvious.

Thanks again, Jonathan