Re: [PATCH v3 30/35] remote-curl: create copy of the service name

From: Jonathan Tan <jonathantanmy@google.com>
Date: Feb 22, 2018, 00:06 UTC
Message-ID: <20180221160606.af3db12daeed08ba68bd37f8@google.com>
In-Reply-To: <20180207011312.189834-31-bmwill@google.com>

On Tue, 6 Feb 2018 17:13:07 -0800 Brandon Williams <bmwill@google.com> wrote:

Show 5 quoted lines

> Make a copy of the service name being requested instead of relying on
> the buffer pointed to by the passed in 'const char *' to remain
> unchanged.
> 
> Signed-off-by: Brandon Williams <bmwill@google.com>

Probably worth mentioning in the commit message:

  Currently, all service names are string constants, but a subsequent
  patch will introduce service names from external sources.

Other than that,

Reviewed-by: Jonathan Tan <jonathantanmy@google.com>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.