Re: [PATCH 00/18] Add `branch-diff`, a `tbdiff` lookalike
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 21, 2018, 04:48 UTC
- Message-ID
- <xmqqvabh1ung.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <cover.1525361419.git.johannes.schindelin@gmx.de>
I've been using both branch-diff and tbdiff while comparing rerolled topics before accepting them. One obvious difference between the two is that the speed to compute pairing is quite different but that is expected ;-)
Another difference that is somewhat irritating is that a SP that leads a context line in a diff hunk that is introduced in the newer iteration is often painted in reverse, and I do not know what aspect of that single SP on these lines the branch-diff wants to pull my attention to.
https://pasteboard.co/Hm9ujI7F.png
In the picture, the three pre-context lines that are all indented by a HT are prefixed by a SP, and that is prefixed by a '+' sign of the outer diff.
We can use --dual-color mode to unsee these but it is somewhat frustrating not to know what the branch-diff program wants to tell me by highlighting the single SPs on these lines.
Thanks.