Re: [PATCH v3 11/20] range-diff: add tests

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 16, 2018, 07:28 UTC
Message-ID: <CAPig+cQB8p1Eo0qyfD78cfSY6N=N9i-KBw5UO2OULXfA8+A=tQ@mail.gmail.com>
In-Reply-To: <3d9e5b0ba383bab3a30b74a96a1d78557e168b7f.1530617166.git.gitgitgadget@gmail.com>

On Tue, Jul 3, 2018 at 7:26 AM Thomas Rast via GitGitGadget <gitgitgadget@gmail.com> wrote:

> These are essentially lifted from https://github.com/trast/tbdiff, with
> light touch-ups to account for the command now being an option of `git
> branch`.

The "option of `git branch`" mention is outdated. Perhaps just drop everything after "...touch-ups" (or mention "range-diff" instead).

Show 9 quoted lines

> Apart from renaming `tbdiff` to `range-diff`, only one test case needed
> to be adjusted: 11 - 'changed message'.
> [...]
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> diff --git a/t/.gitattributes b/t/.gitattributes
> @@ -18,5 +18,6 @@ t[0-9][0-9][0-9][0-9]/* -whitespace
>  /t7500/* eol=lf
> +/t7910/* eol=lf

Does this need to be changed to t3206?

Show 6 quoted lines

>  /t8005/*.txt eol=lf
> diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
> new file mode 100755
> index 000000000..2237c7f4a
> --- /dev/null
> +++ b/t/t3206-range-diff.sh