Re: [PATCH 11/18] branch-diff: add tests
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 4, 2018, 06:42 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1805040841230.77@tvgsbejvaqbjf.bet>
- In-Reply-To
- <8DBB15A6A2AB48C7A9914B5B419E001F@PhilipOakley>
Hi Philip,
On Fri, 4 May 2018, Philip Oakley wrote:
Show 16 quoted lines
> From: "Johannes Schindelin" <johannes.schindelin@gmx.de> > > From: Thomas Rast <tr@thomasrast.ch> > > > > These are essentially lifted from https://github.com/trast/tbdiff, with > > light touch-ups to account for the new command name. > > > > Apart from renaming `tbdiff` to `branch-diff`, only one test case needed > > to be adjusted: 11 - 'changed message'. > > > > The underlying reason it had to be adjusted is that diff generation is > > sometimes ambiguous. In this case, a comment line and an empty line are > > added, but it is ambiguous whether they were added after the existing > > empty line, or whether an empty line and the comment line are added > > *before* the existing emtpy line. And apparently xdiff picks a different > > s/emtpy/empty/
Yep, that has been pointed out by others, too... ;-)
It is good that this thing gets a really good review *grins*
Ciao, Dscho