Re: [PATCH v2 02/18] Add a new builtin: branch-diff

From: Todd Zullinger <tmz@pobox.com>
Date: May 6, 2018, 00:38 UTC
Message-ID: <20180506003842.GT26695@zaya.teonanacatl.net>
In-Reply-To: <20180506002532.GS26695@zaya.teonanacatl.net>

I wrote:

> Would it be possible and reasonable to teach 'git branch' to
> call this as a subcommand, i.e. as 'git branch diff'?  Then
> the completion wouldn't offer git branch-diff.

Of course right after I sent this, it occurred to me that 'git branch diff' would make mask the ability to create a branch named diff. Using 'git branch --diff ...' wouldn't suffer that problem.

It does add a bit more overhead to the 'git branch' command, in terms of documentation and usage. I'm not sure it's too much though. The git-branch summary wouldn't change much:

-git-branch - List, create, or delete branches +git-branch - List, create, delete, or diff branches

I hesitate to hit send again, in case I'm once again overlooking a glaringly obvious problem with this idea. ;)

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Quick to judge, quick to anger, slow to understand.
Ignorance and prejudice and fear walk hand in hand.