Re: [PATCH v2 05/18] branch-diff: also show the diff between patches

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 6, 2018, 12:18 UTC
Message-ID: <nycvar.QRO.7.76.6.1805061411260.77@tvgsbejvaqbjf.bet>
In-Reply-To: <217c9c08-696f-5e96-d42f-d428ad1fe0a0@gmail.com>

Hi Buga,

On Sun, 6 May 2018, Igor Djordjevic wrote:

Show 10 quoted lines

> On 04/05/2018 17:34, Johannes Schindelin wrote:
> > Just like tbdiff, we now show the diff between matching patches. This is
> > a "diff of two diffs", so it can be a bit daunting to read for the
> > beginner.
> > 
> > And just like tbdiff, we now also accept the `--no-patches` option
> > (which is actually equivalent to the diff option `-s`).
> 
> A quick nit - would `--no-patch` (singular form) option name be more 
> aligned with diff `-s` option it resembles?

The reason I used `--no-patches` is that tbdiff called it that way.

But you're right, the functionality is already available via -s, and we *do* make this a distinct thing from tbdiff. So I'll simply drop support for --no-patches.

Ciao, Dscho