Re: [PATCH v2 02/18] Add a new builtin: branch-diff

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 6, 2018, 12:21 UTC
Message-ID: <nycvar.QRO.7.76.6.1805061419530.77@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqk1shsecd.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Sun, 6 May 2018, Junio C Hamano wrote:

Show 18 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Sat, 5 May 2018, Jeff King wrote:
> >
> >> On Fri, May 04, 2018 at 05:34:32PM +0200, Johannes Schindelin wrote:
> >> 
> >> > This builtin does not do a whole lot so far, apart from showing a usage
> >> > that is oddly similar to that of `git tbdiff`. And for a good reason:
> >> > the next commits will turn `branch-diff` into a full-blown replacement
> >> > for `tbdiff`.
> >> 
> >> One minor point about the name: will it become annoying as a tab
> >> completion conflict with git-branch?
> 
> If tbdiff were "Thomas's branch diff", I would call this jbdiff ;-)
> but I think the 't' in there stands for "topic", not "Thomas's".
> 
> How about "git topic-diff"?

Or `git topic-branch-diff`?

But then, we do not really use the term `topic branch` a lot in Git, *and* the operation in question is not really about showing differences between topic branches, but between revisions of topic branches.

So far, the solution I like best is to use `git branch --diff <...>`, which also neatly side-steps the problem of cluttering the top-level command list (because tab completion).

Ciao, Dscho