Re: [PATCH v3 18/20] completion: support `git range-diff`

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 7, 2018, 11:38 UTC
Message-ID: <nycvar.QRO.7.76.6.1807071334480.75@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqpo00geys.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Fri, 6 Jul 2018, Junio C Hamano wrote:

Show 14 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
> 
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > Tab completion of `git range-diff` is very convenient, especially
> > given that the revision arguments to specify the commit ranges to
> > compare are typically more complex than, say, your grandfather's `git
> > log` arguments.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> Have three-dash lines here, or perhaps have some validation hook in
> the garden-shears tool to notice these leftoer bits we see below?

This is just a simple case of me overlooking the `squash!` while rebasing. The shears were not involved, as it is not a branch thicket, it is a simple, linear branch.

I guess I could install some sort of post-rewrite hook, but then, I'd rather have this as a more generally useful feature, directly in `rebase -i`: if running in autosquash mode, when offering to edit squashed commit messages, `git rebase -i` should refuse by default to accept a commit message that contains a line that starts with `squash! `.

Would make for a nice micro-project, methinks.

Show 6 quoted lines

> > squash! WIP completion: support `git range-diff`
> >
> > Revert "WIP completion: support `git range-diff`"
> >
> > This reverts commit 2e7af652af9e53a19fd947f8ebe37a78043afa49.
> > ---

I will fix this in my branch, of course, and force-push, but will wait with sending out a new revision of the patch series in case more reviews roll in.

Ciao, Dscho