Re: [PATCH v3 18/20] completion: support `git range-diff`
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 6, 2018, 22:46 UTC
- Message-ID
- <xmqqpo00geys.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <d05b54c603dc68acf198bb8826e3af4f2f11021f.1530617166.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 8 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de> > > Tab completion of `git range-diff` is very convenient, especially > given that the revision arguments to specify the commit ranges to > compare are typically more complex than, say, your grandfather's `git > log` arguments. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Have three-dash lines here, or perhaps have some validation hook in the garden-shears tool to notice these leftoer bits we see below?
Show 35 quoted lines
>
> squash! WIP completion: support `git range-diff`
>
> Revert "WIP completion: support `git range-diff`"
>
> This reverts commit 2e7af652af9e53a19fd947f8ebe37a78043afa49.
> ---
> contrib/completion/git-completion.bash | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 94c95516e..402490673 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1976,6 +1976,20 @@ _git_push ()
> __git_complete_remote_or_refspec
> }
>
> +_git_range_diff ()
> +{
> + case "$cur" in
> + --*)
> + __gitcomp "
> + --creation-factor= --dual-color
> + $__git_diff_common_options
> + "
> + return
> + ;;
> + esac
> + __git_complete_revlist
> +}
> +
> _git_rebase ()
> {
> __git_find_repo_path