Re: [PATCH v2 00/18] Add `branch-diff`, a `tbdiff` lookalike

From: Elijah Newren <newren@gmail.com>
Date: May 7, 2018, 17:07 UTC
Message-ID: <CABPp-BFQ2y1-FuA1wwnvFefjTFxunM4qeFke6icc5vAPs7k8GQ@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1805052141550.77@tvgsbejvaqbjf.bet>

Hi Dscho,

On Sat, May 5, 2018 at 1:03 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> Hi Elijah,
>
> On Fri, 4 May 2018, Elijah Newren wrote:
>

<snip>

Show 6 quoted lines

>> - tbdiff aligned output columns better when there were more than 9
>> patches (I'll comment more on patch 09/18)
>
> I added a new patch to align the patch numbers specifically. I considered
> squashing it into 9/18, but decided against it: it will make it easier to
> read through the rationale when calling `git annotate` on those lines.

Awesome, thanks.

<snip>

Show 6 quoted lines

>> Also, I don't have bash-completion for either tbdiff or branch-diff.
>> :-(  But I saw some discussion on the v1 patches about how this gets
>> handled...  :-)
>
> Oh? Does 18/18 not work for you?
> https://public-inbox.org/git/71698f11835311c103aae565a2a761d10f4676b9.1525448066.git.johannes.schindelin@gmx.de/

It looks like it does work, in part, there were just two issues:

1) I apparently wasn't using all the nice improvements from the
completion script in my locally built git, but was instead still using
the one associated with my system-installed (and much older) git.
(Oops, my bad.)

2) Your completion commands for branch-diff will only complete one
revision range, not two.  e.g.
    git branch-diff origin/master..my-topic@{2} origin/master..my-top<tab>
won't complete "my-topic" as I'd expect.

Elijah