Re: [PATCH v4 18/21] completion: support `git range-diff`

> On Sat, Jul 21, 2018 at 6:05 PM Johannes Schindelin via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > Tab completion of `git range-diff` is very convenient, especially
> > given that the revision arguments to specify the commit ranges to
> > compare are typically more complex than, say, what is normally passed
> > to `git log`.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> > @@ -1976,6 +1976,20 @@ _git_push ()
> > +_git_range_diff ()
> > +{
> > +  case "$cur" in
> > +  --*)
> > +          __gitcomp "
> > +               --creation-factor= --dual-color
> > +                  $__git_diff_common_options
> > +                  "
> 
> This is indented with a mix of spaces and tabs.
> 
>     Applying: completion: support `git range-diff`
>     .git/rebase-apply/patch:18: space before tab in indent.
>                 --creation-factor= --dual-color
>     warning: 1 line adds whitespace errors.
>     Applying: range-diff: make --dual-color the default mode
>     .git/rebase-apply/patch:105: space before tab in indent.
>                 --creation-factor= --no-dual-color
>     warning: 1 line adds whitespace errors.
> 
> Other parts of this script seem to use tabs for indentation.