Re: [PATCH v4 11/21] range-diff: add tests

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 30, 2018, 16:30 UTC
Message-ID: <nycvar.QRO.7.76.6.1807301830330.10478@tvgsbejvaqbjf.bet>
In-Reply-To: <CAPig+cRd2V_hN0BVCcevXhu1v_QpL76mhqTGQmWPLK7sAD4Ytw@mail.gmail.com>

Hi Eric,

On Sun, 22 Jul 2018, Eric Sunshine wrote:

Show 6 quoted lines

> On Sat, Jul 21, 2018 at 6:05 PM Thomas Rast via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > These are essentially lifted from https://github.com/trast/tbdiff, with
> > light touch-ups to account for the command now being names `git
> 
> s/names/named/

Thanks.

I already pushed an update to https://github.com/gitgitgadget/git/pull/1.

Ciao, Dscho

Show 15 quoted lines

> 
> > range-diff`.
> >
> > Apart from renaming `tbdiff` to `range-diff`, only one test case needed
> > to be adjusted: 11 - 'changed message'.
> >
> > The underlying reason it had to be adjusted is that diff generation is
> > sometimes ambiguous. In this case, a comment line and an empty line are
> > added, but it is ambiguous whether they were added after the existing
> > empty line, or whether an empty line and the comment line are added
> > *before* the existing empty line. And apparently xdiff picks a different
> > option here than Python's difflib.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>