Re: [PATCH v2 13/18] color: provide inverted colors, too

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 7, 2018, 01:20 UTC
Message-ID: <nycvar.QRO.7.76.6.1805062119051.77@tvgsbejvaqbjf.bet>
In-Reply-To: <20180506064104.GB3418@sigill.intra.peff.net>

Hi Peff,

On Sun, 6 May 2018, Jeff King wrote:

Show 20 quoted lines

> On Sun, May 06, 2018 at 02:35:44AM -0400, Jeff King wrote:
> 
> > You'd have to introduce GIT_COLOR_REVERSE. I don't think we have a
> > constant for it yet, but it's \x[7m.
> 
> Heh, of course you knew that already, as I just noticed your patch is
> using the reverse attribute internally (I had thought at first glance
> you were just specifying the background independently).
> 
> So really, I guess all I am arguing for is having GIT_COLOR_INV (or
> REVERSE) as a constant, and then teaching the code to combine it with
> the existing "new" color. It's perfectly OK to have:
> 
>   \x1b[7m\x1b[36m
> 
> instead of:
> 
>   \x1b[7;36m
> 
> It's two extra bytes, but I doubt anybody cares.

Yep, I agree that it is a small price to pay for the benefit of simply using the reverse of diff.color.old (and .new).

While at it, I also changed the hunk header colors: they are *also* simply the same ones, with the outer one having background and foreground reversed.

Ciao, Dscho