Re: [PATCH v3 0/6] use the pager in 'add -p'

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 10, 2024, 20:08 UTC
Message-ID: <xmqqle3c1ryz.fsf@gitster.g>
In-Reply-To: <1a9f8385377d3aadfeb07ad62810b2df@manjaro.org>

Dragan Simic <dsimic@manjaro.org> writes:

Show 10 quoted lines

> If you want to see an example of the garbled output, as a result of the
> coloring escape sequences not being processed correctly, just "cd" into
> your favorite Git repository and run the following commands (assuming
> you're using bash, if not, please adjust the first command):
>
>   export GIT_PAGER='less'
>   git log --patch
>
> I hope that will make more clear why I'm "advocating" for three separate
> new commands for "git add -p", i.e. "P", "|xyz" and ">xyz".

We are talking about folks who use a pager in the context of Git, and to them, your example is totally made-up and irrelevant one.

Either they use a color-enabled pager (like "less -R") or they have configured color.ui to disable coloring. So I do not see this quite as a safety issue.