Re: [PATCH 5/5] add-patch: render hunks through the pager

From: Dragan Simic <dsimic@manjaro.org>
Date: May 23, 2024, 23:28 UTC
Message-ID: <ba1c6fbac4424a4e2c68cb439f9918eb@manjaro.org>
In-Reply-To: <xmqq7cfkqger.fsf@gitster.g>

On 2024-05-24 01:04, Junio C Hamano wrote:

Show 14 quoted lines

> Dragan Simic <dsimic@manjaro.org> writes:
> 
>>> And for usability, perhaps giving a specific command would change
>>> the default program a bare 'P' invokes for the rest of the session
>>> until another specific command overrides.  Another usability hack
>>> may be "[interactive] pipecommand = less -FX" configuration variable
>>> gives the initial default for each session.
>> 
>> I think that would be way too complicated.
> 
> It is modelled after how "less" and "vi" remembers the last pattern
> fed to their "/" command.  You once give, say, "/test_<ENTER>" to
> find one instance of "test_", then "/<ENTER>" takes to the next
> instance.

Huh, less(1) actually remembers nothing when the secure mode is turned on. That's another thing I've collaborated with the author of less(1), to make it possible to remember the last search term when running less(1) in secure mode.

> As I expect our target audiences are used to such a behaviour, I do
> not think I agree with your "way too complicated".

Hmm.  Where would that state be stored?