Re: [PATCH v2 5/5] add-patch: render hunks through the pager

From: Rubén Justo <rjusto@gmail.com>
Date: May 22, 2024, 21:23 UTC
Message-ID: <ff8efadb-4c1a-43ce-9b12-7688d6062c18@gmail.com>
In-Reply-To: <1accd0163c96811b7b7f146e477acf89@manjaro.org>

On Wed, May 22, 2024 at 10:09:25AM +0200, Dragan Simic wrote:

Show 16 quoted lines

> > @@ -1387,7 +1388,7 @@ N_("j - leave this hunk undecided, see next
> > undecided hunk\n"
> >     "/ - search for a hunk matching the given regex\n"
> >     "s - split the current hunk into smaller hunks\n"
> >     "e - manually edit the current hunk\n"
> > -   "p - print the current hunk\n"
> > +   "p - print the current hunk, 'P' to use the pager\n"
> 
> I think it would be better to move the description of "P" into
> a separate line after the "p" line, perhaps like this:
> 
>   "P - use the pager to print the current hunk\n"
> 
> I know, we'd sacrifice one line of the valuable vertical space
> this way, but I find it more consistent and much harder to miss
> the new "P" option.

Making 'P' a /version/ of 'p' allows us to skip adding 'P' to the list of available options:

    (1/1) Stage this hunk [y,n,q,a,d,j,J,k,K,g,/,s,e,p,P,?]

This is what I though and this long list is what worries me.

But I see your point.  I am not opposed to adding a new line.