Re: [PATCH v2 5/5] add-patch: render hunks through the pager

From: Dragan Simic <dsimic@manjaro.org>
Date: May 22, 2024, 08:09 UTC
Message-ID: <1accd0163c96811b7b7f146e477acf89@manjaro.org>
In-Reply-To: <310a2904-681a-4bee-96b9-90a2dc107975@gmail.com>

Hello Ruben,

On 2024-05-21 22:52, Rubén Justo wrote:

Show 13 quoted lines

> Make the print command to trigger the pager when invoked using a 
> capital
> 'P', to make it easier for the user to review long hunks.
> 
> ...
> 
> @@ -1387,7 +1388,7 @@ N_("j - leave this hunk undecided, see next
> undecided hunk\n"
>     "/ - search for a hunk matching the given regex\n"
>     "s - split the current hunk into smaller hunks\n"
>     "e - manually edit the current hunk\n"
> -   "p - print the current hunk\n"
> +   "p - print the current hunk, 'P' to use the pager\n"

I think it would be better to move the description of "P" into a separate line after the "p" line, perhaps like this:

   "P - use the pager to print the current hunk\n"

I know, we'd sacrifice one line of the valuable vertical space this way, but I find it more consistent and much harder to miss the new "P" option.

Overall, I find the introduction of "P" as the new single-character menu option fine. Maybe we can later add "-P" as the new command- line option, if there will be some demand to do that.