Re: [PATCH v3 0/6] use the pager in 'add -p'

Dragan Simic <dsimic@manjaro.org> writes:

I tend to agree that if we do not give a way to toggle between "with" and "without" color when piping to a program, it is safer to make the default uncolored.

The user's configured pager is expected to deal with colors just fine (or the user has globally configured colors to be off). As we are capable of telling if the user is asking to spawn the default pager (by not giving a custom command or by clearing the previous custom command given in the same session) or a custom one, it should be easily doable to give colored version to the configured pager and uncolored version to a custom/one-shot command. Unlike the existing support for (e)dit command, we do not read back from what the command does using the hunk and present it again to the user, it should be a relatively easy and safe thing to do.