Re: [PATCH v3 0/6] use the pager in 'add -p'

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 5, 2024, 17:24 UTC
Message-ID: <xmqq5xunti94.fsf@gitster.g>
In-Reply-To: <20240605090935.GF2345232@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

> Just to note some prior art, mutt's "<pipe-message>" faces a similar
> problem. You might want the raw message (if you're going to poke at
> headers, MIME parts, etc yourself) or you may want a decoded one (if you
> just care about body text and don't want to deal with base64, qp, etc,
> yourself). They provide a stateful config knob, but then you end up with
> horrible macros that toggle the knob, like:
>
>   :set pipe_decode=yes<enter><pipe-message>my-script<enter>:set pipe_decode=no<enter>
>
> I think having two separate commands for the two modes would be less
> confusing.

Yup, I have been suffering from its equivalent in Gnus/Emacs every day, where decoded version of multipart/signed messages look different enough from valid RFC2822 messages and break application with "git am", and there of course is "feed the undecoded original to pipe" option.

But the need for both is pretty much known, and the real issue is that what the default should be. The default destination of the pipe being a pager, making the colored output the default is consistent with that, I would think.

Thanks.