Re: [PATCH v3 0/6] use the pager in 'add -p'
- From
- Dragan Simic <dsimic@manjaro.org>
- Date
- Jun 3, 2024, 10:21 UTC
- Message-ID
- <fb2a9e98f0b2c3a009b0ad800c05522c@manjaro.org>
- In-Reply-To
- <xmqq34pu8kkg.fsf@gitster.g>
On 2024-06-03 11:03, Junio C Hamano wrote:
Show 16 quoted lines
> Dragan Simic <dsimic@manjaro.org> writes: >> On 2024-06-02 18:36, Junio C Hamano wrote: >>> A possibility is to phrase it like so: >>> | - pipe the current hunk to the program (or "%s" by default) >>> and fill %s with the program you'd use if not given, i.e. initially >>> the value of the GIT_PAGER but updated to the last used program >>> after the user uses "|<program>" form to specify one. >> >> The value of GIT_PAGER (or the <program>) can be a rather long string, >> so it would have to be stripped down to the base command, but it would >> be rather error-prone and the printed information would become much >> less >> informative that way. > > I'd probably just say $GIT_PAGER instead of its expansion if we were > go that route.
Makes sense to me. More precisely, the environment should be checked to see is it "$GIT_PAGER" or "$PAGER" that needs to be printed literally as part of the help message.