Re: [PATCH 2/5] pager: do not close fd 2 unnecessarily

From: Junio C Hamano <gitster@pobox.com>
Date: May 21, 2024, 22:00 UTC
Message-ID: <xmqqikz6966t.fsf@gitster.g>
In-Reply-To: <0574914d-8088-434d-8db2-013c1abe27c3@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

> Adding logic to adjust when we close(stderr) in close_pager_fds() makes
> sense on its own, I think.

The feature may be.

> And, the values for the flag "do-we-want-to-close-stderr-at-exit", too,
> to me.

But the thing is, the flag is *NOT* named as such, and an undocumented "value -1 means X, while value 1 means Y", do not make any sense, either.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.