Re: [PATCH v3 0/6] use the pager in 'add -p'
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 3, 2024, 09:03 UTC
- Message-ID
- <xmqq34pu8kkg.fsf@gitster.g>
- In-Reply-To
- <ec2ca25486b84615e30dbeb83ec47310@manjaro.org>
Dragan Simic <dsimic@manjaro.org> writes:
Show 13 quoted lines
> Hello Junio, > > On 2024-06-02 18:36, Junio C Hamano wrote: >> A possibility is to phrase it like so: >> | - pipe the current hunk to the program (or "%s" by default) >> and fill %s with the program you'd use if not given, i.e. initially >> the value of the GIT_PAGER but updated to the last used program >> after the user uses "|<program>" form to specify one. > > The value of GIT_PAGER (or the <program>) can be a rather long string, > so it would have to be stripped down to the base command, but it would > be rather error-prone and the printed information would become much less > informative that way.
I'd probably just say $GIT_PAGER instead of its expansion if we were go that route.