Re: [PATCH v3 0/6] use the pager in 'add -p'

From: Dragan Simic <dsimic@manjaro.org>
Date: Jun 4, 2024, 17:34 UTC
Message-ID: <8bbb3503cee92a66092073d990a9606a@manjaro.org>
In-Reply-To: <xmqqsexu6o60.fsf@gitster.g>

On 2024-06-03 17:28, Junio C Hamano wrote:

Show 12 quoted lines

> Dragan Simic <dsimic@manjaro.org> writes:
> 
>>> I'd probably just say $GIT_PAGER instead of its expansion if we were
>>> go that route.
>> 
>> Makes sense to me.  More precisely, the environment should be checked
>> to see is it "$GIT_PAGER" or "$PAGER" that needs to be printed 
>> literally
>> as part of the help message.
> 
> I was sure somebody will split a hair like that.  At that point we
> are better off mentioning 'git var' X-<.  Or just 'Your Pager'.

I agree that it can be seen as splitting hairs, but the general approach of Git is accuracy, so using "$GIT_PAGER" regardless of it being used or not would be simply against the general approach.

Though, I agree that using "pager" or maybe even "your pager" would be simpler, yet a very good option.