Re: [PATCH v3 0/6] use the pager in 'add -p'

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 4, 2024, 15:32 UTC
Message-ID: <xmqqikyo207f.fsf@gitster.g>
In-Reply-To: <20240604101700.GA1781455@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

>   diff-highlight | less -FX
>
> But after playing with your patch, I realized that:
>
>   - there's no need to pipe through diff-highlight; it already happened
>     as part of interactive.diffFilter!

;-)

>   - since it's triggered manually now, there's no need to add in -FX

I do not know about -X, but yeah, -F is of dubious value in this particular context. You explicitly told us that you want to page, somehow knowing that the hunk needs paging.

> So I am perfectly happy for you to stop where you did. Possibly
> interactive.pipeCommand could be useful in a more general sense, but we
> can wait until somebody encounters that itch.

It makes it sound like if somebody has a use case already we shouldn't stop here ;-)

The default that colors the output is something we might later regret. Those who want colored output can always use the interactive.diffFilter configuration, but I am not sure if going the other direction to strip coloring is just as easy. But other than that, I think we are at an OK place to stop.

Thanks.