Re: [PATCH 5/5] add-patch: render hunks through the pager

From: Junio C Hamano <gitster@pobox.com>
Date: May 20, 2024, 19:30 UTC
Message-ID: <xmqqh6esffh1.fsf@gitster.g>
In-Reply-To: <eb0438e8-d7b6-478f-b2be-336e83f5d9ab@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

> Invoke the pager when displaying hunks during "add -p" sessions, to make
> it easier for the user to review hunks longer than one screen height.

If the hunk fits on one screen, it is annoying to see a pager invoked and then torn down immediately, even with "less -F" (--quit-if-one-screen). As we know how much output we are throwing at the user, we'd want to make this conditional to the size of the hunk being shown and the terminal height.

Or perhaps show them without such a trick, and add a new variant to 'p' that allows the user to request the output be sent to a pager (perhaps 'P')? It would certainly be an alternative with much smaller damage. The existing end-user experience would not degrade, but when the user wants to see a huge hunk, they can send it to the pager.

Another, ulteriour, motive here behind this suggestion is to encourage users to work with smaller hunks. Being able to scroll around and view lines on demand (i.e. use of pager) is one thing. Being able to view all relevant lines at once (i.e. not wasting vertical screen real estate and making things fit on one screen) is very different and much nicer.