Re: [PATCH 4/6] transport: add client support for object-info
On Tue, Jul 9, 2024 at 12:37 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
>
> Toon claes <toon@iotcl.com> writes:
>
> >> + temp_ref->old_oid = *(transport->smart_options->object_info_oids->oid + i);
> >
> > Any reason why you're not using the subscript operator (square brackets)
> > like this:
> >
> > + temp_ref->old_oid = transport->smart_options->object_info_oids->oid[i];
>
> Much nicer, but fold such overly long lines, please,
>
> temp_ref->old_oid = transport->smart_options->
> object_info_oids->oid[i];
>
> to make them readable.
>
>
Thank you, sir. I will follow the folding format in V2.
Show 5 quoted lines
>
> > ...
> > To be honest, I'm not sure it works, because fetch_object_info() always
> > seem to return a non-zero value. I'm not sure this is due to missing
> > code coverage, or a bug. I guess it's worth looking into.
Peijian Ju <eric.peijian@gmail.com>