Re: [PATCH 6/6] cat-file: add remote-object-info to batch-command

From: Toon claes <toon@iotcl.com>
Date: Jul 9, 2024, 07:16 UTC
Message-ID: <87h6czqblk.fsf@iotcl.com>
In-Reply-To: <20240628190503.67389-7-eric.peijian@gmail.com>

Eric Ju <eric.peijian@gmail.com> writes:

Show 18 quoted lines

> diff --git a/builtin/cat-file.c b/builtin/cat-file.c
> index 72a78cdc8c..34958a1747 100644
> --- a/builtin/cat-file.c
> +++ b/builtin/cat-file.c
> ...
> +static int get_remote_info(struct batch_options *opt, int argc, const char **argv)
> +{
> +	int retval = 0;
> +	struct remote *remote = NULL;
> +	struct object_id oid;
> +	struct string_list object_info_options = STRING_LIST_INIT_NODUP;
> +	static struct transport *gtransport;
> +
> +	/*
> +	 * Change the format to "%(objectname) %(objectsize)" when
> +	 * remote-object-info command is used. Once we start supporting objecttype
> +	 * the default format should change to DEFAULT_FORMAT
> +	*/

I believe this comment has become outdated, or got moved around incorrectly.

Show 12 quoted lines

> diff --git a/t/t1017-cat-file-remote-object-info.sh b/t/t1017-cat-file-remote-object-info.sh
> new file mode 100755
> index 0000000000..7a7bdfeb91
> --- /dev/null
> +++ b/t/t1017-cat-file-remote-object-info.sh
> ...
> +stop_git_daemon
> +
> +# Test --batch-command remote-object-info with 'http://' transport
> +
> +. "$TEST_DIRECTORY"/lib-httpd.sh
> +start_httpd

start_httpd skips the remainder of the tests if it fails to start the httpd server. That's why I see various other tests which have this at the end:

  # DO NOT add non-httpd-specific tests here, because the last part of this
  # test script is only executed when httpd is available and enabled.

So I would suggest to add this comment as well, and move the file:// tests above start_httpd.

-- 
Toon