[PATCH GSoC v14 02/13] git-compat-util: add strtoul_szt() with error handling
- From
Pablo Sabater <pabloosabaterr@gmail.com>
- Date
- Jun 25, 2026, 12:13 UTC
- Message-ID
- <20260625-ps-eric-work-rebase-v14-2-09f7ffe21a53@gmail.com>
- In-Reply-To
- <20260625-ps-eric-work-rebase-v14-0-09f7ffe21a53@gmail.com>
From: Eric Ju <eric.peijian@gmail.com>
We already have strtoul_ui() and similar functions that provide proper error handling using strtoul from the standard library. However, there isn't currently a variant that returns an unsigned long.
This variant is needed in a subsequent commit to enable returning an size_t with proper error handling.
Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com> --- git-compat-util.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
diff --git a/git-compat-util.h b/git-compat-util.h index 8809776407..7f417f1acf 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -975,6 +975,26 @@ static inline int strtoul_ui(char const *s, int base, unsigned int *result) return 0; } +/* + * Convert a string to a size_t using the standard library's strtoul, with + * additional error handling to ensure robustness. + */ +static inline int strtoul_szt(char const *s, int base, size_t *result) +{ + unsigned long ul; + char *p; + + errno = 0; + /* negative values would be accepted by strtoul */ + if (strchr(s, '-')) + return -1; + ul = strtoul(s, &p, base); + if (errno || *p || p == s) + return -1; + *result = ul; + return 0; +} + static inline int strtol_i(char const *s, int base, int *result) { long ul;
-- 2.54.0