Re: [PATCH v8 0/6] add remote-object-info to batch-command
Sorry for the noise. I forgot to CC others, so I am resending it.
On Thu, Dec 26, 2024 at 5:56 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
>
> Eric Ju <eric.peijian@gmail.com> writes:
>
> > Range-diff against v7:
> > -: ---------- > 1: c09e21a9d6 cat-file: add declaration of variable i inside its for loop
> > -: ---------- > 2: ed04a4a7c4 fetch-pack: refactor packet writing
> > -: ---------- > 3: bc52c4f80c fetch-pack: move fetch initialization
> > -: ---------- > 4: 4c1b989c41 serve: advertise object-info feature
> > -: ---------- > 5: dbc95a9ae5 transport: add client support for object-info
> > -: ---------- > 6: f244ec8a2f cat-file: add remote-object-info to batch-command
>
> This is curious. Did you compare the right things?
>
Thank you.
I think I may compare it wrong.
Show 12 quoted lines
> --
> 2.47.0
>
> Information Footer:
> base-commit: 8f8d6eee531b3fa1a8ef14f169b0cb5035f7a772
> Merge Request: https://gitlab.com/gitlab-org/git/-/merge_requests/168
>
> If the base-commit information is relevant, please do not write it
> below the "signature" like (i.e. a line that consists only of
> dash-dash-space near the end of the message), as some e-mail programs
> consider them irrelevant and omit from quoting.
>
Show 6 quoted lines
> I tried to apply them on top of 8f8d6eee (The seventh batch,
> 2024-11-01) but the last step [6/6] fails to apply (the first five
> applied cleanly, and matched what I already had).
>
> Could you help to figure out what is going wrong on your end?
>
Should I resend v8 or send a v9 instead?
> Thanks.
Peijian Ju <eric.peijian@gmail.com>