Re: [PATCH v3 4/6] transport: add client support for object-info

From: Peijian Ju <eric.peijian@gmail.com>
Date: Oct 24, 2024, 20:23 UTC
Message-ID: <CAN2LT1D2h-D38F6ELv5Opb1-TdQiFXz88aqA8oxOOfmXw-dTeg@mail.gmail.com>
In-Reply-To: <CAP8UFD0-EPZkdWd8xbg-Yt+aSGfJQE1cFz62Oxwjm-8N1sQ2PQ@mail.gmail.com>

On Wed, Oct 23, 2024 at 5:48 AM Christian Couder <christian.couder@gmail.com> wrote:

Show 22 quoted lines

>
> On Thu, Sep 26, 2024 at 3:39 AM Eric Ju <eric.peijian@gmail.com> wrote:
>
> > +       if (transport->smart_options
> > +               && transport->smart_options->object_info
> > +               && transport->smart_options->object_info_oids->nr > 0) {
> > +               struct ref *ref_itr = object_info_refs = alloc_ref("");
> > +
> > +               if (!fetch_object_info(transport, data->options.object_info_data))
> > +                       goto cleanup;
> > +
> > +               args.object_info_data = data->options.object_info_data;
> > +               args.quiet = 1;
> > +               args.no_progress = 1;
> > +               for (size_t i = 0; i < transport->smart_options->object_info_oids->nr; i++) {
> > +                       ref_itr->old_oid = transport->smart_options->object_info_oids->oid[i];
> > +                       ref_itr->exact_oid = 1;
> > +                       if (i == transport->smart_options->object_info_oids->nr - 1)
> > +                               /* last element, no need to allocate to next */
> > +                               ref_itr -> next = NULL;
>
> Space characters should be removed around "->".

Thank you. It is fixed in v4.

Show 5 quoted lines

>
> > +                       else
> > +                               ref_itr->next = alloc_ref("");
>
> Here for example there are no spaces around "->".