From: Peijian Ju <eric.peijian@gmail.com>
Date: Sat, 13 Jul 2024 02:32:54 GMT
Subject: Re: [PATCH 4/6] transport: add client support for object-info
Message-ID: <CAN2LT1AXfY6efX7kzR4A6kUefZx-KtmL3oDQ3OUine7jbc5haA@mail.gmail.com>
In-Reply-To: <xmqqttgyfrnb.fsf@gitster.g>

On Tue, Jul 9, 2024 at 12:37 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Toon claes <toon@iotcl.com> writes:
>
> >> +                    temp_ref->old_oid = *(transport->smart_options->object_info_oids->oid + i);
> >
> > Any reason why you're not using the subscript operator (square brackets)
> > like this:
> >
> > +                     temp_ref->old_oid = transport->smart_options->object_info_oids->oid[i];
>
> Much nicer, but fold such overly long lines, please,
>
>                         temp_ref->old_oid = transport->smart_options->
>                                 object_info_oids->oid[i];
>
> to make them readable.
>
>

Thank you, sir. I will follow the folding format in V2.

>
> > ...
> > To be honest, I'm not sure it works, because fetch_object_info() always
> > seem to return a non-zero value. I'm not sure this is due to missing
> > code coverage, or a bug. I guess it's worth looking into.