Re: [PATCH v9 1/8] git-compat-util: add strtoul_ul() with error handling

From: Peijian Ju <eric.peijian@gmail.com>
Date: Jan 14, 2025, 01:39 UTC
Message-ID: <CAN2LT1CSbdptV_y7iyWeWrBRNM-ToDm=aHDha1Hc7FHa12bSZg@mail.gmail.com>
In-Reply-To: <CAP8UFD1CoaEzqoCN+_6_qPk_5scf3mhvpCRrsuxc1K=ZObUgiA@mail.gmail.com>

Thank you. Fixed in v10.

On Fri, Jan 10, 2025 at 6:33 AM Christian Couder <christian.couder@gmail.com> wrote:

Show 16 quoted lines

>
> On Wed, Jan 8, 2025 at 7:38 PM Eric Ju <eric.peijian@gmail.com> wrote:
>
> > +// Converts a string to an unsigned long using the standard library's strtoul,
> > +// with additional error handling to ensure robustness.
>
> We use comments like this:
>
> /*
>  * Converts a string to an unsigned long using the standard library's strtoul,
>  * with additional error handling to ensure robustness.
>  */
>
> Also we use the imperative mood in comments before a function, so:
>
> s/Converts/Convert/

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.