git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] cat-file: add remote-object-info to batch-command

From
Karthik Nayak <karthik.188@gmail.com>
Date
Jul 10, 2024, 12:08 UTC
Message-ID
<CAOLa=ZRL8ByTi3+8ej1Ugh75CU5Rx2grGpNx5ESKOJCrEYg2XA@mail.gmail.com>
In-Reply-To
<20240628190503.67389-7-eric.peijian@gmail.com>
Eric Ju <eric.peijian@gmail.com> writes:
Show 15 quoted lines
> From: Calvin Wan <calvinwan@google.com>
>
> Since the `info` command in cat-file --batch-command prints object info
> for a given object, it is natural to add another command in cat-file
> --batch-command to print object info for a given object from a remote.
> Add `remote-object-info` to cat-file --batch-command.
>
> While `info` takes object ids one at a time, this creates overhead when
> making requests to a server so `remote-object-info` instead can take
> multiple object ids at once.
>
> cat-file --batch-command is generally implemented in the following
> manner:
>
>  - Receive and parse input from user
So this refers input delimited by newline or '\0'.
>  - Call respective function attached to command
>  - Set batch mode state, get object info, print object info
>
Doesn't the batch mode get set before the input parsing begins?
Show 24 quoted lines
> In --buffer mode, this changes to:
>
>  - Receive and parse input from user
>  - Store respective function attached to command in a queue
>  - After flush, loop through commands in queue
>     - Call respective function attached to command
>     - Set batch mode state, get object info, print object info
>
> Notice how the getting and printing of object info is accomplished one
> at a time. As described above, this creates a problem for making
> requests to a server. Therefore, `remote-object-info` is implemented in
> the following manner:
>
>  - Receive and parse input from user
>  If command is `remote-object-info`:
>     - Get object info from remote
>     - Loop through object info
>         - Call respective function attached to `info`
>         - Set batch mode state, use passed in object info, print object
>           info
>  Else:
>     - Call respective function attached to command
>     - Parse input, get object info, print object info
>

So this is because we want 'remote-object-info' to also use 'parse_cmd_info' similar to 'info'. But I'm not understanding why, especially since 'parse_cmd_info' calls 'batch_one_object', and we skip most of that code for 'remote-object-info'.

Wouldn't it be cleaner to just define our own 'batch_remote_object' and create 'parse_cmd_remote_info' ?

Show 142 quoted lines
> And finally for --buffer mode `remote-object-info`:
>  - Receive and parse input from user
>  - Store respective function attached to command in a queue
>  - After flush, loop through commands in queue:
>     If command is `remote-object-info`:
>         - Get object info from remote
>         - Loop through object info
>             - Call respective function attached to `info`
>             - Set batch mode state, use passed in object info, print
>               object info
>     Else:
>         - Call respective function attached to command
>         - Set batch mode state, get object info, print object info
>
> To summarize, `remote-object-info` gets object info from the remote and
> then generates multiple `info` commands with the object info passed in.
>
> In order for remote-object-info to avoid remote communication overhead
> in the non-buffer mode, the objects are passed in as such:
>
> remote-object-info <remote> <oid> <oid> ... <oid>
>
> rather than
>
> remote-object-info <remote> <oid>
> remote-object-info <remote> <oid>
> ...
> remote-object-info <remote> <oid>
>
> Signed-off-by: Calvin Wan <calvinwan@google.com>
> Signed-off-by: Eric Ju  <eric.peijian@gmail.com>
> Helped-by: Jonathan Tan <jonathantanmy@google.com>
> Helped-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  Documentation/git-cat-file.txt         |  22 +-
>  builtin/cat-file.c                     | 231 ++++++++++----
>  object-file.c                          |  11 +
>  object-store-ll.h                      |   3 +
>  t/t1017-cat-file-remote-object-info.sh | 412 +++++++++++++++++++++++++
>  5 files changed, 620 insertions(+), 59 deletions(-)
>  create mode 100755 t/t1017-cat-file-remote-object-info.sh
>
> diff --git a/Documentation/git-cat-file.txt b/Documentation/git-cat-file.txt
> index bd95a6c10a..ab0647bb39 100644
> --- a/Documentation/git-cat-file.txt
> +++ b/Documentation/git-cat-file.txt
> @@ -149,6 +149,12 @@ info <object>::
>  	Print object info for object reference `<object>`. This corresponds to the
>  	output of `--batch-check`.
>
> +remote-object-info <remote> <object>...::
> +	Print object info for object references `<object>` at specified <remote> without
> +	downloading object from remote.
> +	Error when no object references is provided.
> +	This command may be combined with `--buffer`.
> +
>  flush::
>  	Used with `--buffer` to execute all preceding commands that were issued
>  	since the beginning or since the last flush was issued. When `--buffer`
> @@ -290,7 +296,8 @@ newline. The available atoms are:
>  	The full hex representation of the object name.
>
>  `objecttype`::
> -	The type of the object (the same as `cat-file -t` reports).
> +	The type of the object (the same as `cat-file -t` reports). See
> +	`CAVEATS` below. Not supported by `remote-object-info`.
>
>  `objectsize`::
>  	The size, in bytes, of the object (the same as `cat-file -s`
> @@ -298,13 +305,14 @@ newline. The available atoms are:
>
>  `objectsize:disk`::
>  	The size, in bytes, that the object takes up on disk. See the
> -	note about on-disk sizes in the `CAVEATS` section below.
> +	note about on-disk sizes in the `CAVEATS` section below. Not
> +	supported by `remote-object-info`.
>
>  `deltabase`::
>  	If the object is stored as a delta on-disk, this expands to the
>  	full hex representation of the delta base object name.
>  	Otherwise, expands to the null OID (all zeroes). See `CAVEATS`
> -	below.
> +	below. Not supported by `remote-object-info`.
>
>  `rest`::
>  	If this atom is used in the output string, input lines are split
> @@ -314,7 +322,9 @@ newline. The available atoms are:
>  	line) are output in place of the `%(rest)` atom.
>
>  If no format is specified, the default format is `%(objectname)
> -%(objecttype) %(objectsize)`.
> +%(objecttype) %(objectsize)`, except remote-object-info command who uses
> +`%(objectname) %(objectsize)` for now because "%(objecttype)" is not supported yet.
> +When "%(objecttype)" is supported, default format should be unified.
>
>  If `--batch` is specified, or if `--batch-command` is used with the `contents`
>  command, the object information is followed by the object contents (consisting
> @@ -396,6 +406,10 @@ scripting purposes.
>  CAVEATS
>  -------
>
> +Note that since objecttype, objectsize:disk and deltabase are currently not supported by the
> +remote-object-info, git will error and exit when they are in the format string.
> +
> +
>  Note that the sizes of objects on disk are reported accurately, but care
>  should be taken in drawing conclusions about which refs or objects are
>  responsible for disk usage. The size of a packed non-delta object may be
> diff --git a/builtin/cat-file.c b/builtin/cat-file.c
> index 72a78cdc8c..34958a1747 100644
> --- a/builtin/cat-file.c
> +++ b/builtin/cat-file.c
> @@ -24,6 +24,9 @@
>  #include "promisor-remote.h"
>  #include "mailmap.h"
>  #include "write-or-die.h"
> +#include "alias.h"
> +#include "remote.h"
> +#include "transport.h"
>
>  enum batch_mode {
>  	BATCH_MODE_CONTENTS,
> @@ -42,9 +45,14 @@ struct batch_options {
>  	char input_delim;
>  	char output_delim;
>  	const char *format;
> +	int use_remote_info;
>  };
>
> +#define DEFAULT_FORMAT "%(objectname) %(objecttype) %(objectsize)"
> +
>  static const char *force_path;
> +static struct object_info *remote_object_info;
> +static struct oid_array object_info_oids = OID_ARRAY_INIT;
>
>  static struct string_list mailmap = STRING_LIST_INIT_NODUP;
>  static int use_mailmap;
> @@ -508,7 +516,6 @@ static void batch_object_write(const char *obj_name,
>  	}
>
>  	batch_write(opt, scratch->buf, scratch->len);
> -
Nit: why remove this?
Show 96 quoted lines
>  	if (opt->batch_mode == BATCH_MODE_CONTENTS) {
>  		print_object_or_die(opt, data);
>  		batch_write(opt, &opt->output_delim, 1);
> @@ -526,51 +533,118 @@ static void batch_one_object(const char *obj_name,
>  		(opt->follow_symlinks ? GET_OID_FOLLOW_SYMLINKS : 0);
>  	enum get_oid_result result;
>
> -	result = get_oid_with_context(the_repository, obj_name,
> -				      flags, &data->oid, &ctx);
> -	if (result != FOUND) {
> -		switch (result) {
> -		case MISSING_OBJECT:
> -			printf("%s missing%c", obj_name, opt->output_delim);
> -			break;
> -		case SHORT_NAME_AMBIGUOUS:
> -			printf("%s ambiguous%c", obj_name, opt->output_delim);
> -			break;
> -		case DANGLING_SYMLINK:
> -			printf("dangling %"PRIuMAX"%c%s%c",
> -			       (uintmax_t)strlen(obj_name),
> -			       opt->output_delim, obj_name, opt->output_delim);
> -			break;
> -		case SYMLINK_LOOP:
> -			printf("loop %"PRIuMAX"%c%s%c",
> -			       (uintmax_t)strlen(obj_name),
> -			       opt->output_delim, obj_name, opt->output_delim);
> -			break;
> -		case NOT_DIR:
> -			printf("notdir %"PRIuMAX"%c%s%c",
> -			       (uintmax_t)strlen(obj_name),
> -			       opt->output_delim, obj_name, opt->output_delim);
> -			break;
> -		default:
> -			BUG("unknown get_sha1_with_context result %d\n",
> -			       result);
> -			break;
> +	if (!opt->use_remote_info) {
> +		result = get_oid_with_context(the_repository, obj_name,
> +						flags, &data->oid, &ctx);
> +		if (result != FOUND) {
> +			switch (result) {
> +			case MISSING_OBJECT:
> +				printf("%s missing%c", obj_name, opt->output_delim);
> +				break;
> +			case SHORT_NAME_AMBIGUOUS:
> +				printf("%s ambiguous%c", obj_name, opt->output_delim);
> +				break;
> +			case DANGLING_SYMLINK:
> +				printf("dangling %"PRIuMAX"%c%s%c",
> +					(uintmax_t)strlen(obj_name),
> +					opt->output_delim, obj_name, opt->output_delim);
> +				break;
> +			case SYMLINK_LOOP:
> +				printf("loop %"PRIuMAX"%c%s%c",
> +					(uintmax_t)strlen(obj_name),
> +					opt->output_delim, obj_name, opt->output_delim);
> +				break;
> +			case NOT_DIR:
> +				printf("notdir %"PRIuMAX"%c%s%c",
> +					(uintmax_t)strlen(obj_name),
> +					opt->output_delim, obj_name, opt->output_delim);
> +				break;
> +			default:
> +				BUG("unknown get_sha1_with_context result %d\n",
> +					result);
> +				break;
> +			}
> +			fflush(stdout);
> +			return;
>  		}
> -		fflush(stdout);
> -		return;
> -	}
>
> -	if (ctx.mode == 0) {
> -		printf("symlink %"PRIuMAX"%c%s%c",
> -		       (uintmax_t)ctx.symlink_path.len,
> -		       opt->output_delim, ctx.symlink_path.buf, opt->output_delim);
> -		fflush(stdout);
> -		return;
> +		if (ctx.mode == 0) {
> +			printf("symlink %"PRIuMAX"%c%s%c",
> +				(uintmax_t)ctx.symlink_path.len,
> +				opt->output_delim, ctx.symlink_path.buf, opt->output_delim);
> +			fflush(stdout);
> +			return;
> +		}
>  	}
>
>  	batch_object_write(obj_name, scratch, opt, data, NULL, 0);
>  }
>
> +static int get_remote_info(struct batch_options *opt, int argc, const char **argv)
> +{
> +	int retval = 0;
> +	struct remote *remote = NULL;
We need to call `remote_clear()` on this at the end.
> +	struct object_id oid;
> +	struct string_list object_info_options = STRING_LIST_INIT_NODUP;
This needs to be cleared.
> +	static struct transport *gtransport;
Shouldn't we call `transport_disconnect(transport);`?
Show 42 quoted lines
> +	/*
> +	 * Change the format to "%(objectname) %(objectsize)" when
> +	 * remote-object-info command is used. Once we start supporting objecttype
> +	 * the default format should change to DEFAULT_FORMAT
> +	*/
> +	if (!opt->format) {
> +		opt->format = "%(objectname) %(objectsize)";
> +	}
> +
> +	remote = remote_get(argv[0]);
> +	if (!remote)
> +		die(_("must supply valid remote when using remote-object-info"));
> +	oid_array_clear(&object_info_oids);
> +	for (size_t i = 1; i < argc; i++) {
> +		if (get_oid_hex(argv[i], &oid))
> +			die(_("Not a valid object name %s"), argv[i]);
> +		oid_array_append(&object_info_oids, &oid);
> +	}
> +
> +	gtransport = transport_get(remote, NULL);
> +	if (gtransport->smart_options) {
> +		int include_size = 0;
> +
> +		CALLOC_ARRAY(remote_object_info, object_info_oids.nr);
> +		gtransport->smart_options->object_info = 1;
> +		gtransport->smart_options->object_info_oids = &object_info_oids;
> +		/*
> +		 * 'size' is the only option currently supported.
> +		 * Other options that are passed in the format will exit with error.
> +		 */
> +		if (strstr(opt->format, "%(objectsize)")) {
> +			string_list_append(&object_info_options, "size");
> +			include_size = 1;
> +		}
> +		if (strstr(opt->format, "%(objecttype)")) {
> +			die(_("objecttype is currently not supported with remote-object-info"));
> +		}
> +		if (strstr(opt->format, "%(objectsize:disk)"))
> +			die(_("objectsize:disk is currently not supported with remote-object-info"));
> +		if (strstr(opt->format, "%(deltabase)"))
> +			die(_("deltabase is currently not supported with remote-object-info"));
>
This whole block could be replaced by an else..
if (strstr(opt->format, "%(objectsize)")) {
	string_list_append(&object_info_options, "size");
	include_size = 1;
} else {
	die(_("%s is currently not supported with remote-object-info", opt->format));
}
Show 64 quoted lines
> +		if (object_info_options.nr > 0) {
> +			gtransport->smart_options->object_info_options = &object_info_options;
> +			for (size_t i = 0; i < object_info_oids.nr; i++) {
> +				if (include_size)
> +					remote_object_info[i].sizep = xcalloc(1, sizeof(long));
> +			}
> +			gtransport->smart_options->object_info_data = &remote_object_info;
> +			retval = transport_fetch_refs(gtransport, NULL);
> +		}
> +	} else {
> +		retval = -1;
> +	}
> +
> +	return retval;
> +}
> +
>  struct object_cb_data {
>  	struct batch_options *opt;
>  	struct expand_data *expand;
> @@ -642,6 +716,7 @@ typedef void (*parse_cmd_fn_t)(struct batch_options *, const char *,
>  struct queued_cmd {
>  	parse_cmd_fn_t fn;
>  	char *line;
> +	const char *name;
>  };
>
>  static void parse_cmd_contents(struct batch_options *opt,
> @@ -662,6 +737,55 @@ static void parse_cmd_info(struct batch_options *opt,
>  	batch_one_object(line, output, opt, data);
>  }
>
> +static const struct parse_cmd {
> +	const char *name;
> +	parse_cmd_fn_t fn;
> +	unsigned takes_args;
> +} commands[] = {
> +	{ "contents", parse_cmd_contents, 1 },
> +	{ "info", parse_cmd_info, 1 },
> +	{ "remote-object-info", parse_cmd_info, 1 },
> +	{ "flush", NULL, 0 },
> +};
> +
> +static void parse_remote_info(struct batch_options *opt,
> +			   char *line,
> +			   struct strbuf *output,
> +			   struct expand_data *data,
> +			   const struct parse_cmd *p_cmd,
> +			   struct queued_cmd *q_cmd)
> +{
> +	int count;
> +	const char **argv;
> +
> +	count = split_cmdline(line, &argv);
> +	if (get_remote_info(opt, count, argv))
> +		goto cleanup;
> +	opt->use_remote_info = 1;
> +	data->skip_object_info = 1;
> +	data->mark_query = 0;
> +	for (size_t i = 0; i < object_info_oids.nr; i++) {
> +		if (remote_object_info[i].sizep)
> +			data->size = *remote_object_info[i].sizep;
> +		if (remote_object_info[i].typep)
> +			data->type = *remote_object_info[i].typep;
> +
We don't even set the type, so this shouldn't ever be possible right?
Show 14 quoted lines
> +		data->oid = object_info_oids.oid[i];
> +		if (p_cmd)
> +			p_cmd->fn(opt, argv[i+1], output, data);
> +		else
> +			q_cmd->fn(opt, argv[i+1], output, data);
> +	}
> +	opt->use_remote_info = 0;
> +	data->skip_object_info = 0;
> +	data->mark_query = 1;
> +
> +cleanup:
> +	for (size_t i = 0; i < object_info_oids.nr; i++)
> +		free_object_info_contents(&remote_object_info[i]);
> +	free(remote_object_info);
argv needs to free'd too
Show 45 quoted lines
> +}
> +
>  static void dispatch_calls(struct batch_options *opt,
>  		struct strbuf *output,
>  		struct expand_data *data,
> @@ -671,8 +795,12 @@ static void dispatch_calls(struct batch_options *opt,
>  	if (!opt->buffer_output)
>  		die(_("flush is only for --buffer mode"));
>
> -	for (int i = 0; i < nr; i++)
> -		cmd[i].fn(opt, cmd[i].line, output, data);
> +	for (int i = 0; i < nr; i++) {
> +		if (!strcmp(cmd[i].name, "remote-object-info"))
> +			parse_remote_info(opt, cmd[i].line, output, data, NULL, &cmd[i]);
> +		else
> +			cmd[i].fn(opt, cmd[i].line, output, data);
> +	}
>
>  	fflush(stdout);
>  }
> @@ -685,17 +813,6 @@ static void free_cmds(struct queued_cmd *cmd, size_t *nr)
>  	*nr = 0;
>  }
>
> -
> -static const struct parse_cmd {
> -	const char *name;
> -	parse_cmd_fn_t fn;
> -	unsigned takes_args;
> -} commands[] = {
> -	{ "contents", parse_cmd_contents, 1},
> -	{ "info", parse_cmd_info, 1},
> -	{ "flush", NULL, 0},
> -};
> -
>  static void batch_objects_command(struct batch_options *opt,
>  				    struct strbuf *output,
>  				    struct expand_data *data)
> @@ -740,11 +857,17 @@ static void batch_objects_command(struct batch_options *opt,
>  			dispatch_calls(opt, output, data, queued_cmd, nr);
>  			free_cmds(queued_cmd, &nr);
>  		} else if (!opt->buffer_output) {
> -			cmd->fn(opt, p, output, data);
> +			if (!strcmp(cmd->name, "remote-object-info")) {
> +				char *line = xstrdup_or_null(p);
This needs to be free'd.
> +				parse_remote_info(opt, line, output, data, cmd, NULL);
Show 83 quoted lines
> +			} else {
> +				cmd->fn(opt, p, output, data);
> +			}
>  		} else {
>  			ALLOC_GROW(queued_cmd, nr + 1, alloc);
>  			call.fn = cmd->fn;
>  			call.line = xstrdup_or_null(p);
> +			call.name = cmd->name;
>  			queued_cmd[nr++] = call;
>  		}
>  	}
> @@ -761,8 +884,6 @@ static void batch_objects_command(struct batch_options *opt,
>  	strbuf_release(&input);
>  }
>
> -#define DEFAULT_FORMAT "%(objectname) %(objecttype) %(objectsize)"
> -
>  static int batch_objects(struct batch_options *opt)
>  {
>  	struct strbuf input = STRBUF_INIT;
> diff --git a/object-file.c b/object-file.c
> index d3cf4b8b2e..6aaa167942 100644
> --- a/object-file.c
> +++ b/object-file.c
> @@ -2988,3 +2988,14 @@ int read_loose_object(const char *path,
>  		munmap(map, mapsize);
>  	return ret;
>  }
> +
> +void free_object_info_contents(struct object_info *object_info)
> +{
> +	if (!object_info)
> +		return;
> +	free(object_info->typep);
> +	free(object_info->sizep);
> +	free(object_info->disk_sizep);
> +	free(object_info->delta_base_oid);
> +	free(object_info->type_name);
> +}
> diff --git a/object-store-ll.h b/object-store-ll.h
> index c5f2bb2fc2..333e19cd1e 100644
> --- a/object-store-ll.h
> +++ b/object-store-ll.h
> @@ -533,4 +533,7 @@ int for_each_object_in_pack(struct packed_git *p,
>  int for_each_packed_object(each_packed_object_fn, void *,
>  			   enum for_each_object_flags flags);
>
> +/* Free pointers inside of object_info, but not object_info itself */
> +void free_object_info_contents(struct object_info *object_info);
> +
>  #endif /* OBJECT_STORE_LL_H */
> diff --git a/t/t1017-cat-file-remote-object-info.sh b/t/t1017-cat-file-remote-object-info.sh
> new file mode 100755
> index 0000000000..7a7bdfeb91
> --- /dev/null
> +++ b/t/t1017-cat-file-remote-object-info.sh
> @@ -0,0 +1,412 @@
> +#!/bin/sh
> +
> +test_description='git cat-file --batch-command with remote-object-info command'
> +
> +GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
> +export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
> +
> +. ./test-lib.sh
> +
> +echo_without_newline () {
> +    printf '%s' "$*"
> +}
> +
> +strlen () {
> +    echo_without_newline "$1" | wc -c | sed -e 's/^ *//'
> +}
> +
> +hello_content="Hello World"
> +hello_size=$(strlen "$hello_content")
> +hello_oid=$(echo_without_newline "$hello_content" | git hash-object --stdin)
> +
> +tree_size=$(($(test_oid rawsz) + 13))
> +
> +commit_message="Initial commit"
> +commit_size=$(($(test_oid hexsz) + 137))
>
Why 13 and 137?
Show 43 quoted lines
> +
> +tag_header_without_oid="type blob
> +tag hellotag
> +tagger $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>"
> +tag_header_without_timestamp="object $hello_oid
> +$tag_header_without_oid"
> +tag_description="This is a tag"
> +tag_content="$tag_header_without_timestamp 0 +0000
> +
> +$tag_description"
> +
> +tag_oid=$(echo_without_newline "$tag_content" | git hash-object -t tag --stdin -w)
> +tag_size=$(strlen "$tag_content")
> +
> +# This section tests --batch-command with remote-object-info command
> +# Since "%(objecttype)" is currently not supported by the command remote-object-info ,
> +# the filters are set to "%(objectname) %(objectsize)".
> +# Tests with the default filter are used to test the fallback to 'fetch' command
> +
> +
> +# Test --batch-command remote-object-info with 'git://' transport
> +
> +. "$TEST_DIRECTORY"/lib-git-daemon.sh
> +start_git_daemon --export-all --enable=receive-pack
> +daemon_parent=$GIT_DAEMON_DOCUMENT_ROOT_PATH/parent
> +
> +test_expect_success 'create repo to be served by git-daemon' '
> +	git init "$daemon_parent" &&
> +
> +	echo_without_newline "$hello_content" > $daemon_parent/hello &&
> +	git -C "$daemon_parent" update-index --add hello &&
> +	git -C "$daemon_parent" config transfer.advertiseobjectinfo true
> +'
> +
> +set_transport_variables () {
> +	hello_sha1=$(echo_without_newline "$hello_content" | git hash-object --stdin)
> +	tree_sha1=$(git -C "$1" write-tree)
> +	commit_sha1=$(echo_without_newline "$commit_message" | git -C "$1" commit-tree $tree_sha1)
> +	tag_sha1=$(echo_without_newline "$tag_content" | git -C "$1" hash-object -t tag --stdin -w)
> +	tag_size=$(strlen "$tag_content")
> +}
> +
> +
extra newline here
Show 344 quoted lines
> +test_expect_success 'batch-command remote-object-info git://' '
> +	(
> +		set_transport_variables "$daemon_parent" &&
> +		cd "$daemon_parent" &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +		git cat-file --batch-command="%(objectname) %(objectsize)" >actual <<-EOF &&
> +		remote-object-info "$GIT_DAEMON_URL/parent" $hello_sha1
> +		remote-object-info "$GIT_DAEMON_URL/parent" $tree_sha1
> +		remote-object-info "$GIT_DAEMON_URL/parent" $commit_sha1
> +		remote-object-info "$GIT_DAEMON_URL/parent" $tag_sha1
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_expect_success 'batch-command remote-object-info git:// multiple sha1 per line' '
> +	(
> +		set_transport_variables "$daemon_parent" &&
> +		cd "$daemon_parent" &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +		git cat-file --batch-command="%(objectname) %(objectsize)" >actual <<-EOF &&
> +		remote-object-info "$GIT_DAEMON_URL/parent" $hello_sha1 $tree_sha1 $commit_sha1 $tag_sha1
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_expect_success 'batch-command remote-object-info http:// default filter' '
> +	(
> +		set_transport_variables "$daemon_parent" &&
> +		cd "$daemon_parent" &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +		GIT_TRACE_PACKET=1 git cat-file --batch-command >actual <<-EOF &&
> +		remote-object-info "$GIT_DAEMON_URL/parent" $hello_sha1 $tree_sha1
> +		remote-object-info "$GIT_DAEMON_URL/parent" $commit_sha1 $tag_sha1
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_expect_success 'batch-command --buffer remote-object-info git://' '
> +	(
> +		set_transport_variables "$daemon_parent" &&
> +		cd "$daemon_parent" &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +		git cat-file --batch-command="%(objectname) %(objectsize)" --buffer >actual <<-EOF &&
> +		remote-object-info "$GIT_DAEMON_URL/parent" $hello_sha1 $tree_sha1
> +		remote-object-info "$GIT_DAEMON_URL/parent" $commit_sha1 $tag_sha1
> +		flush
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +stop_git_daemon
> +
> +# Test --batch-command remote-object-info with 'http://' transport
> +
> +. "$TEST_DIRECTORY"/lib-httpd.sh
> +start_httpd
> +
> +test_expect_success 'create repo to be served by http:// transport' '
> +	git init "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config http.receivepack true &&
> +	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config transfer.advertiseobjectinfo true &&
> +	echo_without_newline "$hello_content" > $HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello &&
> +	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" update-index --add hello
> +'
> +
> +
> +test_expect_success 'batch-command remote-object-info http://' '
> +	(
> +		set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		cd "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +		git cat-file --batch-command="%(objectname) %(objectsize)" >actual <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $hello_sha1
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $tree_sha1
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $commit_sha1
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $tag_sha1
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_expect_success 'batch-command remote-object-info http:// one line' '
> +	(
> +		set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		cd "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +		git cat-file --batch-command="%(objectname) %(objectsize)" >actual <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $hello_sha1 $tree_sha1 $commit_sha1 $tag_sha1
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_expect_success 'batch-command --buffer remote-object-info http://' '
> +	(
> +		set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		cd "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +
> +		git cat-file --batch-command="%(objectname) %(objectsize)" --buffer >actual <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $hello_sha1 $tree_sha1
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $commit_sha1 $tag_sha1
> +		flush
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_expect_success 'batch-command remote-object-info http:// default filter' '
> +	(
> +		set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		cd "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +
> +		git cat-file --batch-command >actual <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $hello_sha1 $tree_sha1
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $commit_sha1 $tag_sha1
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_expect_success 'remote-object-info fails on unspported filter option (objectsize:disk)' '
> +	(
> +		set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		cd "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +
> +		test_must_fail git cat-file --batch-command="%(objectsize:disk)" 2>err <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $hello_sha1
> +		EOF
> +		test_grep "objectsize:disk is currently not supported with remote-object-info" err
> +	)
> +'
> +
> +test_expect_success 'remote-object-info fails on unspported filter option (deltabase)' '
> +	(
> +		set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		cd "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +
> +		test_must_fail git cat-file --batch-command="%(deltabase)" 2>err <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $hello_sha1
> +		EOF
> +		test_grep "deltabase is currently not supported with remote-object-info" err
> +	)
> +'
> +
> +test_expect_success 'remote-object-info fails on server with legacy protocol' '
> +	(
> +		set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		cd "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +
> +		test_must_fail git -c protocol.version=0 cat-file --batch-command="%(objectname) %(objectsize)" 2>err <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $hello_sha1
> +		EOF
> +		test_grep "remote-object-info requires protocol v2" err
> +	)
> +'
> +
> +test_expect_success 'remote-object-info fails on server with legacy protocol fallback' '
> +	(
> +		set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		cd "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +
> +		test_must_fail git -c protocol.version=0 cat-file --batch-command 2>err <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $hello_sha1
> +		EOF
> +		test_grep "remote-object-info requires protocol v2" err
> +	)
> +'
> +
> +test_expect_success 'remote-object-info fails on malformed OID' '
> +	(
> +		set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		cd "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		malformed_object_id="this_id_is_not_valid" &&
> +
> +		test_must_fail git cat-file --batch-command="%(objectname) %(objectsize)" 2>err <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $malformed_object_id
> +		EOF
> +		test_grep "Not a valid object name '$malformed_object_id'" err
> +	)
> +'
> +
> +test_expect_success 'remote-object-info fails on malformed OID fallback' '
> +	(
> +		set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		cd "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		malformed_object_id="this_id_is_not_valid" &&
> +
> +		test_must_fail git cat-file --batch-command 2>err <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $malformed_object_id
> +		EOF
> +		test_grep "Not a valid object name '$malformed_object_id'" err
> +	)
> +'
> +
> +test_expect_success 'remote-object-info fails on missing OID' '
> +	set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +	git clone "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" missing_oid_repo &&
> +	test_commit -C missing_oid_repo message1 c.txt &&
> +	(
> +		cd missing_oid_repo &&
> +
> +		object_id=$(git rev-parse message1:c.txt) &&
> +		test_must_fail git cat-file --batch-command="%(objectname) %(objectsize)" 2>err <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $object_id
> +		EOF
> +		test_grep "object-info: not our ref $object_id" err
> +	)
> +'
> +
> +# shellcheck disable=SC2016
> +test_expect_success 'remote-object-info fails on missing OID fallback' '
> +	(
> +		set_transport_variables "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> +		cd missing_oid_repo &&
> +		object_id=$(git rev-parse message1:c.txt) &&
> +		test_must_fail git cat-file --batch-command 2>err <<-EOF &&
> +		remote-object-info "$HTTPD_URL/smart/http_parent" $object_id
> +		EOF
> +		test_grep "fatal: object-info: not our ref $object_id" err
> +	)
> +'
> +
> +# Test --batch-command remote-object-info with 'file://' transport
> +
> +# shellcheck disable=SC2016
> +test_expect_success 'create repo to be served by file:// transport' '
> +	git init server &&
> +	git -C server config protocol.version 2 &&
> +	git -C server config transfer.advertiseobjectinfo true &&
> +	echo_without_newline "$hello_content" > server/hello &&
> +	git -C server update-index --add hello
> +'
> +
> +
> +test_expect_success 'batch-command remote-object-info file://' '
> +	(
> +		set_transport_variables "server" &&
> +		cd server &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +		git cat-file --batch-command="%(objectname) %(objectsize)" >actual <<-EOF &&
> +		remote-object-info "file://$(pwd)" $hello_sha1
> +		remote-object-info "file://$(pwd)" $tree_sha1
> +		remote-object-info "file://$(pwd)" $commit_sha1
> +		remote-object-info "file://$(pwd)" $tag_sha1
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_expect_success 'batch-command remote-object-info file:// multiple sha1 per line' '
> +	(
> +		set_transport_variables "server" &&
> +		cd server &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +		git cat-file --batch-command="%(objectname) %(objectsize)" >actual <<-EOF &&
> +		remote-object-info "file://$(pwd)" $hello_sha1 $tree_sha1 $commit_sha1 $tag_sha1
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_expect_success 'batch-command --buffer remote-object-info file://' '
> +	(
> +		set_transport_variables "server" &&
> +		cd server &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +		git cat-file --batch-command="%(objectname) %(objectsize)" --buffer >actual <<-EOF &&
> +		remote-object-info "file://$(pwd)" $hello_sha1 $tree_sha1
> +		remote-object-info "file://$(pwd)" $commit_sha1 $tag_sha1
> +		flush
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_expect_success 'batch-command remote-object-info file:// default filter' '
> +	(
> +		set_transport_variables "server" &&
> +		cd server &&
> +
> +		echo "$hello_sha1 $hello_size" >expect &&
> +		echo "$tree_sha1 $tree_size" >>expect &&
> +		echo "$commit_sha1 $commit_size" >>expect &&
> +		echo "$tag_sha1 $tag_size" >>expect &&
> +
> +		git cat-file --batch-command >actual <<-EOF &&
> +		remote-object-info "file://$(pwd)" $hello_sha1 $tree_sha1
> +		remote-object-info "file://$(pwd)" $commit_sha1 $tag_sha1
> +		EOF
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_done
Some more tests I'd like to see
- Testing against the '-Z' option.
- Testing the fallback to fetch whole object when the server doesn't
support 'remote-object-info'.
Thanks
Previous: Peijian JuNext: Peijian Ju
Message 24 of 397 in “cat-file: add remote-object-info to batch-command”
  1. 0/6 cat-file: add remote-object-info to batch-commandEric Ju, Jun 28, 2024
  2. 1/6 fetch-pack: refactor packet writingEric Ju, Jun 28, 2024
  3. Karthik NayakJul 4, 2024
  4. Peijian JuJul 8, 2024
  5. Karthik NayakJul 10, 2024
  6. Peijian JuJul 15, 2024
  7. 2/6 fetch-pack: move fetch initializationEric Ju, Jun 28, 2024
  8. 3/6 serve: advertise object-info featureEric Ju, Jun 28, 2024
  9. 4/6 transport: add client support for object-infoEric Ju, Jun 28, 2024
  10. Toon claesJul 9, 2024
  11. Junio C HamanoJul 9, 2024
  12. Peijian JuJul 13, 2024
  13. Peijian JuJul 13, 2024
  14. Karthik NayakJul 10, 2024
  15. Peijian JuJul 16, 2024
  16. 5/6 cat-file: add declaration of variable i inside its for loopEric Ju, Jun 28, 2024
  17. Karthik NayakJul 10, 2024
  18. Peijian JuJul 16, 2024
  19. 6/6 cat-file: add remote-object-info to batch-commandEric Ju, Jun 28, 2024
  20. Justin ToblerJul 9, 2024
  21. Peijian JuJul 12, 2024
  22. Toon claesJul 9, 2024
  23. Peijian JuJul 13, 2024
  24. Karthik NayakJul 10, 2024
  25. Peijian JuJul 17, 2024
  26. 0/6 cat-file: add remote-object-info to batch-commandEric Ju, Jul 20, 2024
  27. 1/6 fetch-pack: refactor packet writingEric Ju, Jul 20, 2024
  28. Christian CouderSep 24, 2024
  29. Peijian JuSep 25, 2024
  30. 2/6 fetch-pack: move fetch initializationEric Ju, Jul 20, 2024
  31. 3/6 serve: advertise object-info featureEric Ju, Jul 20, 2024
  32. 4/6 transport: add client support for object-infoEric Ju, Jul 20, 2024
  33. Christian CouderSep 24, 2024
  34. Junio C HamanoSep 24, 2024
  35. Peijian JuSep 25, 2024
  36. 5/6 cat-file: add declaration of variable i inside its for loopEric Ju, Jul 20, 2024
  37. 6/6 cat-file: add remote-object-info to batch-commandEric Ju, Jul 20, 2024
  38. Toon ClaesSep 11, 2024
  39. Peijian JuSep 25, 2024
  40. Christian CouderSep 24, 2024
  41. Peijian JuSep 25, 2024
  42. Peijian JuAug 22, 2024
  43. 0/6 cat-file: add remote-object-info to batch-commandEric Ju, Sep 26, 2024
  44. 1/6 fetch-pack: refactor packet writingEric Ju, Sep 26, 2024
  45. 2/6 fetch-pack: move fetch initializationEric Ju, Sep 26, 2024
  46. 3/6 serve: advertise object-info featureEric Ju, Sep 26, 2024
  47. 4/6 transport: add client support for object-infoEric Ju, Sep 26, 2024
  48. Christian CouderOct 23, 2024
  49. Peijian JuOct 24, 2024
  50. 5/6 cat-file: add declaration of variable i inside its for loopEric Ju, Sep 26, 2024
  51. 6/6 cat-file: add remote-object-info to batch-commandEric Ju, Sep 26, 2024
  52. Christian CouderOct 23, 2024
  53. Taylor BlauOct 23, 2024
  54. Peijian JuOct 24, 2024
  55. Peijian JuOct 24, 2024
  56. 0/6 cat-file: add remote-object-info to batch-commandEric Ju, Oct 24, 2024
  57. 1/6 fetch-pack: refactor packet writingEric Ju, Oct 24, 2024
  58. karthik nayakOct 25, 2024
  59. Peijian JuOct 25, 2024
  60. 2/6 fetch-pack: move fetch initializationEric Ju, Oct 24, 2024
  61. 3/6 serve: advertise object-info featureEric Ju, Oct 24, 2024
  62. 4/6 transport: add client support for object-infoEric Ju, Oct 24, 2024
  63. karthik nayakOct 25, 2024
  64. Peijian JuOct 28, 2024
  65. 5/6 cat-file: add declaration of variable i inside its for loopEric Ju, Oct 24, 2024
  66. 6/6 cat-file: add remote-object-info to batch-commandEric Ju, Oct 24, 2024
  67. karthik nayakOct 25, 2024
  68. Christian CouderOct 25, 2024
  69. Taylor BlauOct 25, 2024
  70. Peijian JuOct 27, 2024
  71. Taylor BlauOct 28, 2024
  72. 0/6 cat-file: add remote-object-info to batch-commandEric Ju, Oct 28, 2024
  73. 1/6 fetch-pack: refactor packet writingEric Ju, Oct 28, 2024
  74. Christian CouderNov 5, 2024
  75. Junio C HamanoNov 6, 2024
  76. Peijian JuNov 6, 2024
  77. Peijian JuNov 6, 2024
  78. 2/6 fetch-pack: move fetch initializationEric Ju, Oct 28, 2024
  79. 3/6 serve: advertise object-info featureEric Ju, Oct 28, 2024
  80. 4/6 transport: add client support for object-infoEric Ju, Oct 28, 2024
  81. 5/6 cat-file: add declaration of variable i inside its for loopEric Ju, Oct 28, 2024
  82. 6/6 cat-file: add remote-object-info to batch-commandEric Ju, Oct 28, 2024
  83. 0/6 cat-file: add remote-object-info to batch-commandEric Ju, Nov 8, 2024
  84. 1/6 cat-file: add declaration of variable i inside its for loopEric Ju, Nov 8, 2024
  85. 2/6 fetch-pack: refactor packet writingEric Ju, Nov 8, 2024
  86. 3/6 fetch-pack: move fetch initializationEric Ju, Nov 8, 2024
  87. 4/6 serve: advertise object-info featureEric Ju, Nov 8, 2024
  88. 5/6 transport: add client support for object-infoEric Ju, Nov 8, 2024
  89. 6/6 cat-file: add remote-object-info to batch-commandEric Ju, Nov 8, 2024
  90. Junio C HamanoNov 11, 2024
  91. Peijian JuNov 18, 2024
  92. Junio C HamanoNov 19, 2024
  93. Patrick SteinhardtNov 19, 2024
  94. Junio C HamanoNov 19, 2024
  95. Peijian JuNov 19, 2024
  96. Junio C HamanoNov 20, 2024
  97. 0/6 cat-file: add remote-object-info to batch-commandEric Ju, Nov 25, 2024
  98. 1/6 cat-file: add declaration of variable i inside its for loopEric Ju, Nov 25, 2024
  99. Patrick SteinhardtNov 25, 2024
  100. Peijian JuDec 3, 2024
  101. 2/6 fetch-pack: refactor packet writingEric Ju, Nov 25, 2024
  102. Patrick SteinhardtNov 25, 2024
  103. Peijian JuDec 3, 2024
  104. 3/6 fetch-pack: move fetch initializationEric Ju, Nov 25, 2024
  105. 4/6 serve: advertise object-info featureEric Ju, Nov 25, 2024
  106. 5/6 transport: add client support for object-infoEric Ju, Nov 25, 2024
  107. Patrick SteinhardtNov 25, 2024
  108. Peijian JuDec 3, 2024
  109. 6/6 cat-file: add remote-object-info to batch-commandEric Ju, Nov 25, 2024
  110. Patrick SteinhardtNov 25, 2024
  111. Peijian JuDec 3, 2024
  112. Patrick SteinhardtDec 5, 2024
  113. Christian CouderDec 5, 2024
  114. 0/6 add remote-object-info to batch-commandEric Ju, Dec 23, 2024
  115. 1/6 cat-file: add declaration of variable i inside its for loopEric Ju, Dec 23, 2024
  116. 2/6 fetch-pack: refactor packet writingEric Ju, Dec 23, 2024
  117. 3/6 fetch-pack: move fetch initializationEric Ju, Dec 23, 2024
  118. 4/6 serve: advertise object-info featureEric Ju, Dec 23, 2024
  119. 5/6 transport: add client support for object-infoEric Ju, Dec 23, 2024
  120. Calvin WanJan 7, 2025
  121. Junio C HamanoJan 7, 2025
  122. Peijian JuJan 8, 2025
  123. 6/6 cat-file: add remote-object-info to batch-commandEric Ju, Dec 23, 2024
  124. Calvin WanJan 7, 2025
  125. Junio C HamanoDec 26, 2024
  126. Peijian JuDec 30, 2024
  127. 0/8 cat-file: add remote-object-info to batch-commandEric Ju, Jan 8, 2025
  128. 1/8 git-compat-util: add strtoul_ul() with error handlingEric Ju, Jan 8, 2025
  129. Christian CouderJan 10, 2025
  130. Peijian JuJan 14, 2025
  131. 2/8 cat-file: add declaration of variable i inside its for loopEric Ju, Jan 8, 2025
  132. Christian CouderJan 10, 2025
  133. Peijian JuJan 14, 2025
  134. 3/8 cat-file: split test utility functions into a separate library fileEric Ju, Jan 8, 2025
  135. Christian CouderJan 10, 2025
  136. Peijian JuJan 14, 2025
  137. 4/8 fetch-pack: refactor packet writingEric Ju, Jan 8, 2025
  138. 5/8 fetch-pack: move fetch initializationEric Ju, Jan 8, 2025
  139. 6/8 serve: advertise object-info featureEric Ju, Jan 8, 2025
  140. 7/8 transport: add client support for object-infoEric Ju, Jan 8, 2025
  141. 8/8 cat-file: add remote-object-info to batch-commandEric Ju, Jan 8, 2025
  142. Christian CouderJan 10, 2025
  143. Peijian JuJan 14, 2025
  144. 0/8 cat-file: add remote-object-info to batch-commandEric Ju, Jan 14, 2025
  145. 1/8 git-compat-util: add strtoul_ul() with error handlingEric Ju, Jan 14, 2025
  146. 2/8 cat-file: add declaration of variable i inside its for loopEric Ju, Jan 14, 2025
  147. 3/8 t1006: split test utility functions into new "lib-cat-file.sh"Eric Ju, Jan 14, 2025
  148. 5/8 fetch-pack: move fetch initializationEric Ju, Jan 14, 2025
  149. 4/8 fetch-pack: refactor packet writingEric Ju, Jan 14, 2025
  150. 6/8 serve: advertise object-info featureEric Ju, Jan 14, 2025
  151. 7/8 transport: add client support for object-infoEric Ju, Jan 14, 2025
  152. Jeff KingFeb 1, 2025
  153. Peijian JuFeb 20, 2025
  154. 8/8 cat-file: add remote-object-info to batch-commandEric Ju, Jan 14, 2025
  155. Jeff KingFeb 1, 2025
  156. Peijian JuFeb 21, 2025
  157. Jeff KingFeb 24, 2025
  158. Peijian JuMar 12, 2025
  159. 0/8 cat-file: add remote-object-info to batch-commandEric Ju, Feb 21, 2025
  160. 1/8 git-compat-util: add strtoul_ul() with error handlingEric Ju, Feb 21, 2025
  161. 2/8 cat-file: add declaration of variable i inside its for loopEric Ju, Feb 21, 2025
  162. 4/8 fetch-pack: refactor packet writingEric Ju, Feb 21, 2025
  163. 3/8 t1006: split test utility functions into new "lib-cat-file.sh"Eric Ju, Feb 21, 2025
  164. 5/8 fetch-pack: move fetch initializationEric Ju, Feb 21, 2025
  165. 6/8 serve: advertise object-info featureEric Ju, Feb 21, 2025
  166. 7/8 transport: add client support for object-infoEric Ju, Feb 21, 2025
  167. 8/8 cat-file: add remote-object-info to batch-commandEric Ju, Feb 21, 2025
  168. Junio C HamanoFeb 24, 2025
  169. Peijian JuMar 11, 2025
  170. Jeff KingFeb 24, 2025
  171. Peijian JuMar 12, 2025
  172. Jeff KingMar 13, 2025
  173. Peijian JuMar 21, 2025
  174. Jeff KingMar 24, 2025
  175. [GSoC] Re: [PATCH v11 8/8] cat-file: add remote-object-info to batch-commandPablo Sabater, Mar 12, 2026
  176. 00/12 cat-file: add remote-object-info to batch-commandPablo Sabater, Jun 8, 2026
  177. 01/12 transport-helper: fix memory leak of helper on disconnectPablo Sabater, Jun 8, 2026
  178. 02/12 git-compat-util: add strtoul_ul() with error handlingPablo Sabater, Jun 8, 2026
  179. Chandra PratapJun 9, 2026
  180. 03/12 cat-file: add declaration of variable i inside its for loopPablo Sabater, Jun 8, 2026
  181. Junio C HamanoJun 8, 2026
  182. Pablo SabaterJun 9, 2026
  183. 04/12 t1006: split test utility functions into new "lib-cat-file.sh"Pablo Sabater, Jun 8, 2026
  184. Chandra PratapJun 9, 2026
  185. Pablo SabaterJun 9, 2026
  186. 05/12 fetch-pack: move function to connect.cPablo Sabater, Jun 8, 2026
  187. 06/12 connect: refactor packet writingPablo Sabater, Jun 8, 2026
  188. 07/12 fetch-pack: move fetch initializationPablo Sabater, Jun 8, 2026
  189. 08/12 serve: advertise object-info featurePablo Sabater, Jun 8, 2026
  190. 09/12 transport: add client support for object-infoPablo Sabater, Jun 8, 2026
  191. Junio C HamanoJun 16, 2026
  192. Junio C HamanoJun 16, 2026
  193. 10/12 cat-file: add remote-object-info to batch-commandPablo Sabater, Jun 8, 2026
  194. 11/12 cat-file: validate remote atoms with allow_listPablo Sabater, Jun 8, 2026
  195. 12/12 cat-file: make remote-object-info allow-list dynamicPablo Sabater, Jun 8, 2026
  196. Chandra PratapJun 9, 2026
  197. Pablo SabaterJun 9, 2026
  198. Chandra PratapJun 17, 2026
  199. Junio C HamanoJun 9, 2026
  200. 00/12 cat-file: add remote-object-info to batch-commandPablo Sabater, Jun 19, 2026
  201. 01/12 transport-helper: fix memory leak of helper on disconnectPablo Sabater, Jun 19, 2026
  202. 02/12 git-compat-util: add strtoul_ul() with error handlingPablo Sabater, Jun 19, 2026
  203. Pablo SabaterJun 19, 2026
  204. 03/12 cat-file: declare loop counter inside for()Pablo Sabater, Jun 19, 2026
  205. Karthik NayakJun 22, 2026
  206. 04/12 t1006: split test utility functions into new "lib-cat-file.sh"Pablo Sabater, Jun 19, 2026
  207. Pablo SabaterJun 19, 2026
  208. 05/12 fetch-pack: move function to connect.cPablo Sabater, Jun 19, 2026
  209. Chandra PratapJun 21, 2026
  210. Pablo SabaterJun 24, 2026
  211. Karthik NayakJun 22, 2026
  212. Pablo SabaterJun 24, 2026
  213. 06/12 connect: refactor packet writingPablo Sabater, Jun 19, 2026
  214. Karthik NayakJun 22, 2026
  215. Pablo SabaterJun 24, 2026
  216. Karthik NayakJun 24, 2026
  217. Junio C HamanoJun 24, 2026
  218. Karthik NayakJun 26, 2026
  219. 07/12 fetch-pack: move fetch initializationPablo Sabater, Jun 19, 2026
  220. 08/12 serve: advertise object-info featurePablo Sabater, Jun 19, 2026
  221. 09/12 transport: add client support for object-infoPablo Sabater, Jun 19, 2026
  222. 10/12 cat-file: add remote-object-info to batch-commandPablo Sabater, Jun 19, 2026
  223. Chandra PratapJun 21, 2026
  224. Junio C HamanoJun 21, 2026
  225. 11/12 cat-file: validate remote atoms with allow_listPablo Sabater, Jun 19, 2026
  226. 12/12 cat-file: make remote-object-info allow-list dynamicPablo Sabater, Jun 19, 2026
  227. Chandra PratapJun 21, 2026
  228. Chandra PratapJun 21, 2026
  229. Chandra PratapJun 21, 2026
  230. 00/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jun 25, 2026
  231. 01/13 transport-helper: fix memory leak of helper on disconnectPablo Sabater, Jun 25, 2026
  232. 02/13 git-compat-util: add strtoul_szt() with error handlingPablo Sabater, Jun 25, 2026
  233. Junio C HamanoJun 25, 2026
  234. Pablo SabaterJun 26, 2026
  235. Karthik NayakJun 26, 2026
  236. 03/13 cat-file: declare loop counter inside for()Pablo Sabater, Jun 25, 2026
  237. 04/13 t1006: split test utility functions into new "lib-cat-file.sh"Pablo Sabater, Jun 25, 2026
  238. 05/13 fetch-pack: prepare function to be movedPablo Sabater, Jun 25, 2026
  239. Chandra PratapJun 26, 2026
  240. Karthik NayakJun 26, 2026
  241. Pablo SabaterJun 27, 2026
  242. 06/13 fetch-pack: move function to connect.cPablo Sabater, Jun 25, 2026
  243. Chandra PratapJun 26, 2026
  244. Pablo SabaterJun 27, 2026
  245. Karthik NayakJun 26, 2026
  246. Pablo SabaterJun 27, 2026
  247. 07/13 connect: refactor packet writingPablo Sabater, Jun 25, 2026
  248. Karthik NayakJun 26, 2026
  249. Pablo SabaterJun 27, 2026
  250. 08/13 fetch-pack: move fetch initializationPablo Sabater, Jun 25, 2026
  251. 09/13 serve: advertise object-info featurePablo Sabater, Jun 25, 2026
  252. Karthik NayakJun 26, 2026
  253. Pablo SabaterJun 27, 2026
  254. Karthik NayakJun 28, 2026
  255. 10/13 transport: add client support for object-infoPablo Sabater, Jun 25, 2026
  256. Karthik NayakJun 27, 2026
  257. Pablo SabaterJun 27, 2026
  258. 11/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jun 25, 2026
  259. Karthik NayakJun 27, 2026
  260. Pablo SabaterJun 27, 2026
  261. 12/13 cat-file: validate remote atoms with allow_listPablo Sabater, Jun 25, 2026
  262. 13/13 cat-file: make remote-object-info allow-list dynamicPablo Sabater, Jun 25, 2026
  263. 00/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 1, 2026
  264. 01/13 transport-helper: fix memory leak of helper on disconnectPablo Sabater, Jul 1, 2026
  265. 02/13 git-compat-util: add `strtoumax_szt()` with error handlingPablo Sabater, Jul 1, 2026
  266. Junio C HamanoJul 1, 2026
  267. Pablo SabaterJul 7, 2026
  268. Junio C HamanoJul 7, 2026
  269. Pablo SabaterJul 7, 2026
  270. 03/13 cat-file: declare loop counter inside for()Pablo Sabater, Jul 1, 2026
  271. 04/13 t1006: split test utility functions into new 'lib-cat-file.sh'Pablo Sabater, Jul 1, 2026
  272. 05/13 fetch-pack: drop static `advertise_sid` variablePablo Sabater, Jul 1, 2026
  273. Junio C HamanoJul 1, 2026
  274. 06/13 fetch-pack: move `write_fetch_command_and_capabilities()` to connect.cPablo Sabater, Jul 1, 2026
  275. 07/13 connect: make `write_fetch_command_and_capabilities()` more genericPablo Sabater, Jul 1, 2026
  276. 08/13 fetch-pack: move fetch initializationPablo Sabater, Jul 1, 2026
  277. 09/13 serve: advertise object-info featurePablo Sabater, Jul 1, 2026
  278. 10/13 transport: add client support for object-infoPablo Sabater, Jul 1, 2026
  279. 11/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 1, 2026
  280. 12/13 cat-file: validate remote atoms with an allow-listPablo Sabater, Jul 1, 2026
  281. 13/13 cat-file: make remote-object-info allow-list dynamicPablo Sabater, Jul 1, 2026
  282. 00/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 10, 2026
  283. 01/13 transport-helper: fix memory leak of helper on disconnectPablo Sabater, Jul 10, 2026
  284. 02/13 cat-file: declare loop counter inside for()Pablo Sabater, Jul 10, 2026
  285. 03/13 t1006: split test utility functions into new 'lib-cat-file.sh'Pablo Sabater, Jul 10, 2026
  286. 04/13 fetch-pack: fix hash_algo variable typePablo Sabater, Jul 10, 2026
  287. 05/13 fetch-pack: drop static advertise_sid variablePablo Sabater, Jul 10, 2026
  288. 06/13 fetch-pack: move write_fetch_command_and_capabilities() to connect.cPablo Sabater, Jul 10, 2026
  289. 07/13 connect: make write_fetch_command_and_capabilities() more genericPablo Sabater, Jul 10, 2026
  290. 08/13 fetch-pack: move fetch initializationPablo Sabater, Jul 10, 2026
  291. 09/13 serve: advertise object-info featurePablo Sabater, Jul 10, 2026
  292. 10/13 transport: add client support for object-infoPablo Sabater, Jul 10, 2026
  293. Pablo SabaterJul 14, 2026
  294. 11/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 10, 2026
  295. 12/13 cat-file: validate remote atoms with an allow-listPablo Sabater, Jul 10, 2026
  296. 13/13 cat-file: make remote-object-info allow-list dynamicPablo Sabater, Jul 10, 2026
  297. Chandra PratapJul 12, 2026
  298. 00/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 14, 2026
  299. 01/13 transport-helper: fix memory leak of helper on disconnectPablo Sabater, Jul 14, 2026
  300. 02/13 cat-file: declare loop counter inside for()Pablo Sabater, Jul 14, 2026
  301. 03/13 t1006: split test utility functions into new 'lib-cat-file.sh'Pablo Sabater, Jul 14, 2026
  302. 04/13 fetch-pack: fix hash_algo variable typePablo Sabater, Jul 14, 2026
  303. 05/13 fetch-pack: drop static advertise_sid variablePablo Sabater, Jul 14, 2026
  304. 06/13 fetch-pack: move write_fetch_command_and_capabilities() to connect.cPablo Sabater, Jul 14, 2026
  305. 07/13 connect: make write_fetch_command_and_capabilities() more genericPablo Sabater, Jul 14, 2026
  306. 08/13 fetch-pack: move fetch initializationPablo Sabater, Jul 14, 2026
  307. 09/13 serve: advertise object-info featurePablo Sabater, Jul 14, 2026
  308. 10/13 transport: add client support for object-infoPablo Sabater, Jul 14, 2026
  309. Junio C HamanoJul 14, 2026
  310. Pablo SabaterJul 14, 2026
  311. 11/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 14, 2026
  312. 12/13 cat-file: validate remote atoms with an allow-listPablo Sabater, Jul 14, 2026
  313. 13/13 cat-file: make remote-object-info allow-list dynamicPablo Sabater, Jul 14, 2026
  314. Junio C HamanoJul 14, 2026
  315. Pablo SabaterJul 14, 2026
  316. Junio C HamanoJul 15, 2026
  317. Pablo SabaterJul 15, 2026
  318. Junio C HamanoJul 15, 2026
  319. Pablo SabaterJul 15, 2026
  320. 00/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 15, 2026
  321. 01/13 transport-helper: fix memory leak of helper on disconnectPablo Sabater, Jul 15, 2026
  322. 02/13 cat-file: declare loop counter inside for()Pablo Sabater, Jul 15, 2026
  323. 03/13 t1006: split test utility functions into new 'lib-cat-file.sh'Pablo Sabater, Jul 15, 2026
  324. 04/13 fetch-pack: fix hash_algo variable typePablo Sabater, Jul 15, 2026
  325. 05/13 fetch-pack: drop static advertise_sid variablePablo Sabater, Jul 15, 2026
  326. Karthik NayakJul 15, 2026
  327. Pablo SabaterJul 16, 2026
  328. 06/13 fetch-pack: move write_fetch_command_and_capabilities() to connect.cPablo Sabater, Jul 15, 2026
  329. 07/13 connect: make write_fetch_command_and_capabilities() more genericPablo Sabater, Jul 15, 2026
  330. 08/13 fetch-pack: move fetch initializationPablo Sabater, Jul 15, 2026
  331. 09/13 serve: advertise object-info featurePablo Sabater, Jul 15, 2026
  332. 10/13 transport: add client support for object-infoPablo Sabater, Jul 15, 2026
  333. Junio C HamanoJul 15, 2026
  334. Pablo SabaterJul 15, 2026
  335. Junio C HamanoJul 16, 2026
  336. 11/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 15, 2026
  337. Junio C HamanoJul 15, 2026
  338. Pablo SabaterJul 15, 2026
  339. Karthik NayakJul 15, 2026
  340. 12/13 cat-file: validate remote atoms with an allow-listPablo Sabater, Jul 15, 2026
  341. 13/13 cat-file: make remote-object-info allow-list dynamicPablo Sabater, Jul 15, 2026
  342. Junio C HamanoJul 15, 2026
  343. Pablo SabaterJul 15, 2026
  344. Junio C HamanoJul 15, 2026
  345. Pablo SabaterJul 15, 2026
  346. Junio C HamanoJul 16, 2026
  347. Pablo SabaterJul 16, 2026
  348. Karthik NayakJul 15, 2026
  349. 00/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 17, 2026
  350. 01/13 transport-helper: fix memory leak of helper on disconnectPablo Sabater, Jul 17, 2026
  351. 02/13 cat-file: declare loop counter inside for()Pablo Sabater, Jul 17, 2026
  352. 04/13 fetch-pack: drop the static advertise_sid variablePablo Sabater, Jul 17, 2026
  353. 03/13 t1006: extract helper functions into new 'lib-cat-file.sh'Pablo Sabater, Jul 17, 2026
  354. 05/13 fetch-pack: move write_fetch_command_and_capabilities() to connect.cPablo Sabater, Jul 17, 2026
  355. SZEDER GáborJul 18, 2026
  356. Pablo SabaterJul 18, 2026
  357. 06/13 connect: use unsigned int for hash_algo_by_name() callsPablo Sabater, Jul 17, 2026
  358. 07/13 connect: make write_fetch_command_and_capabilities() more genericPablo Sabater, Jul 17, 2026
  359. 08/13 fetch-pack: move fetch initializationPablo Sabater, Jul 17, 2026
  360. 09/13 protocol-caps: check object existence regardless of the attributes requestedPablo Sabater, Jul 17, 2026
  361. 10/13 serve: advertise object-info featurePablo Sabater, Jul 17, 2026
  362. 11/13 transport: add client support for object-infoPablo Sabater, Jul 17, 2026
  363. 12/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 17, 2026
  364. 13/13 cat-file: make remote-object-info allow-list adapt to the serverPablo Sabater, Jul 17, 2026
  365. 00/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 18, 2026
  366. 01/13 transport-helper: fix memory leak of helper on disconnectPablo Sabater, Jul 18, 2026
  367. 02/13 cat-file: declare loop counter inside for()Pablo Sabater, Jul 18, 2026
  368. 03/13 t1006: extract helper functions into new 'lib-cat-file.sh'Pablo Sabater, Jul 18, 2026
  369. 04/13 fetch-pack: drop the static advertise_sid variablePablo Sabater, Jul 18, 2026
  370. 05/13 fetch-pack: use unsigned int for hash_algo variablePablo Sabater, Jul 18, 2026
  371. 06/13 fetch-pack: move write_fetch_command_and_capabilities() to connect.cPablo Sabater, Jul 18, 2026
  372. 07/13 connect: make write_fetch_command_and_capabilities() more genericPablo Sabater, Jul 18, 2026
  373. 08/13 fetch-pack: move fetch initializationPablo Sabater, Jul 18, 2026
  374. 09/13 protocol-caps: check object existence regardless of the attributes requestedPablo Sabater, Jul 18, 2026
  375. 10/13 serve: advertise object-info featurePablo Sabater, Jul 18, 2026
  376. 11/13 transport: add client support for object-infoPablo Sabater, Jul 18, 2026
  377. 12/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 18, 2026
  378. 13/13 cat-file: make remote-object-info allow-list adapt to the serverPablo Sabater, Jul 18, 2026
  379. Karthik NayakJul 21, 2026
  380. Pablo SabaterJul 22, 2026
  381. Karthik NayakJul 22, 2026
  382. Pablo SabaterJul 22, 2026
  383. 00/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 24, 2026
  384. 01/13 transport-helper: fix memory leak of helper on disconnectPablo Sabater, Jul 24, 2026
  385. 02/13 cat-file: declare loop counter inside for()Pablo Sabater, Jul 24, 2026
  386. 03/13 t1006: extract helper functions into new 'lib-cat-file.sh'Pablo Sabater, Jul 24, 2026
  387. 04/13 fetch-pack: drop the static advertise_sid variablePablo Sabater, Jul 24, 2026
  388. 05/13 fetch-pack: use unsigned int for hash_algo variablePablo Sabater, Jul 24, 2026
  389. 06/13 fetch-pack: move write_fetch_command_and_capabilities() to connect.cPablo Sabater, Jul 24, 2026
  390. 07/13 connect: make write_fetch_command_and_capabilities() more genericPablo Sabater, Jul 24, 2026
  391. 08/13 fetch-pack: move fetch initializationPablo Sabater, Jul 24, 2026
  392. 09/13 protocol-caps: check object existence regardless of the attributes requestedPablo Sabater, Jul 24, 2026
  393. 10/13 serve: advertise object-info featurePablo Sabater, Jul 24, 2026
  394. 11/13 transport: add client support for object-infoPablo Sabater, Jul 24, 2026
  395. 12/13 cat-file: add remote-object-info to batch-commandPablo Sabater, Jul 24, 2026
  396. 13/13 cat-file: make remote-object-info allow-list adapt to the serverPablo Sabater, Jul 24, 2026
  397. Junio C HamanoJul 24, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.