[PATCH GSoC v20 05/13] fetch-pack: use unsigned int for hash_algo variable
- From
Pablo Sabater <pabloosabaterr@gmail.com>
- Date
- Jul 18, 2026, 21:49 UTC
- Message-ID
- <20260718-ps-eric-work-rebase-v20-5-0c13962ac532@gmail.com>
- In-Reply-To
- <20260718-ps-eric-work-rebase-v20-0-0c13962ac532@gmail.com>
hash_algo_by_name() returns unsigned int, but it is stored in hash_algo variable as int. This goes unnoticed because of:
DISABLE_SIGN_COMPARE_WARNINGS
On 'fetch-pack.c'
On a subsequent commit this function will be moved to 'connect.c' that would notice this.
Change hash_algo variable type to match its return type, also make it const because they are never modified.
Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com> --- fetch-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fetch-pack.c b/fetch-pack.c index 65ebfec09f..f1e64160fc 100644 --- a/fetch-pack.c +++ b/fetch-pack.c @@ -1397,7 +1397,7 @@ static void write_fetch_command_and_capabilities(struct strbuf *req_buf, } if (server_feature_v2("object-format", &hash_name)) { - int hash_algo = hash_algo_by_name(hash_name); + const unsigned int hash_algo = hash_algo_by_name(hash_name); if (hash_algo_by_ptr(the_hash_algo) != hash_algo) die(_("mismatched algorithms: client %s; server %s"), the_hash_algo->name, hash_name);
-- 2.54.0