[PATCH GSoC v21 01/13] transport-helper: fix memory leak of helper on disconnect
- From
Pablo Sabater <pabloosabaterr@gmail.com>
- Date
- Jul 24, 2026, 10:54 UTC
- Message-ID
- <20260724-ps-eric-work-rebase-v21-1-ba67f024fdff@gmail.com>
- In-Reply-To
- <20260724-ps-eric-work-rebase-v21-0-ba67f024fdff@gmail.com>
disconnect_helper() only frees data inside of the if(data->helper) block [1]. When the transport is disconnected without the helper being fully started, data->name allocated in transport_helper_init() is never freed.
Move FREE_AND_NULL(data->name) outside the conditional block so it's always freed on disconnect.
[1]: https://lore.kernel.org/git/05fbadbae2184479c87c37675dde7bd79b3e32ab.1716465556.git.ps@pks.im/
Mentored-by: Karthik Nayak <karthik.188@gmail.com> Mentored-by: Chandra Pratap <chandrapratap3519@gmail.com> Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com> --- transport-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/transport-helper.c b/transport-helper.c index 80f90eb7ba..f195070788 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -266,9 +266,9 @@ static int disconnect_helper(struct transport *transport) close(data->helper->out); fclose(data->out); res = finish_command(data->helper); - FREE_AND_NULL(data->name); FREE_AND_NULL(data->helper); } + FREE_AND_NULL(data->name); return res; }
-- 2.54.0