Re: [PATCH GSoC v14 07/13] connect: refactor packet writing

From: Pablo Sabater <pabloosabaterr@gmail.com>
Date: Jun 27, 2026, 20:58 UTC
Message-ID: <CAN5EUNTZ+m1v90K2bivD1ZTNPc0jFPt4LseN-B-mGbifYHj5RQ@mail.gmail.com>
In-Reply-To: <CAOLa=ZTdcg47nmZs2t1FvyOgG9S4Ap3RaK+C0Dhku6cG+wj_Kw@mail.gmail.com>

El vie, 26 jun 2026 a las 19:03, Karthik Nayak (<karthik.188@gmail.com>) escribió:

Show 7 quoted lines

>
> Pablo Sabater <pabloosabaterr@gmail.com> writes:
>
> The subject is bit too generic no? Maybe we can talk about the function?
> Perhaps:
>
>     connect: make `write_fetch_command_and_capabilities()` more generic

Okay, I'll use that as the subject.

Show 14 quoted lines

>
> > Refactor `write_fetch_command_and_capabilities()`, enabling it to serve
> > both fetch and additional commands.
> >
> > In this context, "command" refers to the "operations" supported by
> > Git's wire protocol https://git-scm.com/docs/protocol-v2, such as a Git
> > subcommand (e.g., git-fetch(1)) or a server-side operation like
> > "object-info" as implemented in commit a2ba162
> > (object-info: support for retrieving object info, 2021-04-20).
> >
> > Refactor the function signature to accept a command instead of the
> > hardcoded "fetch".
>
> [snip]

Thanks for the feedback, Pablo.