Re: [PATCH v2 4/6] transport: add client support for object-info

> On Sat, Jul 20, 2024 at 5:43 AM Eric Ju <eric.peijian@gmail.com> wrote:
>
> [...]
>
>>  fetch-pack.c       |  24 +++++++++
>>  fetch-pack.h       |  10 ++++
>>  transport-helper.c |   8 ++-
>>  transport.c        | 118 +++++++++++++++++++++++++++++++++++++++++++--
>>  transport.h        |  11 +++++
>>  5 files changed, 164 insertions(+), 7 deletions(-)
>
> Karthik suggested adding tests at this stage, but I see no tests here.
> Maybe the tests are added later, but I agree with Karthik that it
> would be nice to add them early if possible.
> ...
>> +       if (args.object_info) {
>> +               struct ref *ref_cpy_reader = object_info_refs;
>> +               for (int i = 0; ref_cpy_reader; i++) {
>> +                       oid_object_info_extended(the_repository, &ref_cpy_reader->old_oid, &args.object_info_data[i], OBJECT_INFO_LOOKUP_REPLACE);
>
> This line might want to be folded.