Re: [PATCH v3 4/6] transport: add client support for object-info

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 23, 2024, 09:48 UTC
Message-ID: <CAP8UFD0-EPZkdWd8xbg-Yt+aSGfJQE1cFz62Oxwjm-8N1sQ2PQ@mail.gmail.com>
In-Reply-To: <20240926013856.35527-5-eric.peijian@gmail.com>

On Thu, Sep 26, 2024 at 3:39 AM Eric Ju <eric.peijian@gmail.com> wrote:

Show 17 quoted lines

> +       if (transport->smart_options
> +               && transport->smart_options->object_info
> +               && transport->smart_options->object_info_oids->nr > 0) {
> +               struct ref *ref_itr = object_info_refs = alloc_ref("");
> +
> +               if (!fetch_object_info(transport, data->options.object_info_data))
> +                       goto cleanup;
> +
> +               args.object_info_data = data->options.object_info_data;
> +               args.quiet = 1;
> +               args.no_progress = 1;
> +               for (size_t i = 0; i < transport->smart_options->object_info_oids->nr; i++) {
> +                       ref_itr->old_oid = transport->smart_options->object_info_oids->oid[i];
> +                       ref_itr->exact_oid = 1;
> +                       if (i == transport->smart_options->object_info_oids->nr - 1)
> +                               /* last element, no need to allocate to next */
> +                               ref_itr -> next = NULL;

Space characters should be removed around "->".

> +                       else
> +                               ref_itr->next = alloc_ref("");

Here for example there are no spaces around "->".