Re: [PATCH v6 0/5] Reftable support git-core

From

Jonathan Nieder <jrnieder@gmail.com>

Date

Feb 26, 2020, 17:41 UTC

Message-ID

<20200226174117.GA103006@google.com>

In-Reply-To

<CAFQ2z_NQn9O3kFmHk8Cr31FY66ToU4bUdE=asHUfN++zBG+SPw@mail.gmail.com>

> You have convinced me that we should go with the 4-byte identifier.
>
> How about setting version=2 and extending the header by 4 bytes (which hold
> the 4-byte identifier). The footer would also be increased in size.

SGTM.

> BTW, could we document that a reftable consisting of just a footer is a
> valid table too?

Yes, SGTM as well.