Re: [PATCH 0/5] Reftable support git-core
- From
Han-Wen Nienhuys <hanwen@xs4all.nl>
- Date
- Jan 27, 2020, 13:52 UTC
- Message-ID
- <CAOw_e7Y7w2Az65iuzWT5SHLv+iHwFZ=ZE11TFS=m0Vh59M2a=A@mail.gmail.com>
- In-Reply-To
- <xmqqy2tx3l1y.fsf@gitster-ct.c.googlers.com>
On Thu, Jan 23, 2020 at 10:44 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> > This adds the reftable library, and hooks it up as a ref backend. > > Just a quick impression before getting into details of individual > steps. > > * With this series, the reftable backend seems to take over as the > default and only backend. We would need to design and decide how > repositories would specify which backend it uses (I personally do > not think we need to allow more than one backend to be active at > the same time) before we take this series out of RFC status.
Yes, obviously. Would you have concrete ideas on how this should work?
> * What's reftable/VERSION file? Does it really have what you > intended to add?
Fixed, and explained in reftable/VERSION.
> * Mixed indentation and many whitespace breakages make the code > distracting to review.
Do you mean in the changes to refs/reftable-backend.c? Or the imported code?
The imported code is uniformly formatted with clang-format.
Is there a clang-format setting for uniformly formatting to Linux/Git style? I really love automated formatting, so we don't have to spend time debating irrelevant details.
Show 8 quoted lines
> > * Comparison with 0 is written as "if (!strcmp(a, b))" in this > codebase, and never "if (0 != strcmp(a, b))". > > * We unfortunately do not use var defn "for (int i = 0; ..." yet. > > * We do not use // comments. >
fixed.