Re: Re* [PATCH v19 03/20] checkout: add '\n' to reflog message
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Jul 6, 2020, 15:56 UTC
- Message-ID
- <CAFQ2z_MEEUHu-NnAgg-8ZV5mgOTFDvo4OApRwuCo7=3H9DQc6g@mail.gmail.com>
- In-Reply-To
- <xmqqr1tvc7el.fsf_-_@gitster.c.googlers.com>
On Wed, Jul 1, 2020 at 10:22 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> In any case, a patch that moves the existing "squash SPs and rtrim" > cleansing from the files backend to the generic layer may look like > the attached patch. We can add reftable backend on top of a change > like this one and then we do not have to worry about each backend > cleansing the incoming reflog messages the same way. Nice?
Yes, very nice! Will you merge this, or should I make this part of the reftable series? The reftable code already has normalization for reflog messages, so it doesn't really make a difference; either way is fine.
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado