Re: [PATCH 0/5] Reftable support git-core
- From
Stephan Beyer <s-beyer@gmx.net>
- Date
- Jan 23, 2020, 22:45 UTC
- Message-ID
- <cdf5fd5a-49ac-cc0c-8da4-68c82cdd883c@gmx.net>
- In-Reply-To
- <pull.539.git.1579808479.gitgitgadget@gmail.com>
Hi Han-Wen,
On 1/23/20 8:41 PM, Han-Wen Nienhuys via GitGitGadget wrote:
Show 8 quoted lines
> This adds the reftable library, and hooks it up as a ref backend. > > Han-Wen Nienhuys (5): > setup.c: enable repo detection for reftable > create .git/refs in files-backend.c > Document how ref iterators and symrefs interact > Add reftable library > Reftable support for git-core
I am most of the time just a curious reader on this list but as someone who has no idea what the reftable library does (except that it can serve as a "ref backend"), I would expect much more elaborate commit messages. In particular, patch 4/5 (i.e. the commit message of the "add reftable library" commit) should describe the purpose of the reftable library at least briefly; and patch 5/5 should not contain shell commands and output without context but a short description why the patch is doing what it is doing. For example, if the use of the reftable library makes certain git commands a lot faster, it should state that.
Thanks.
Stephan