Re: [PATCH v6 4/5] Add reftable library
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Feb 19, 2020, 17:00 UTC
- Message-ID
- <CAFQ2z_MfZ5_eO3vp4yKH2KBTSg-1ePP8+qvCMRMOjbzpOrHoHw@mail.gmail.com>
- In-Reply-To
- <20200219065533.GA623000@coredump.intra.peff.net>
On Wed, Feb 19, 2020 at 7:55 AM Jeff King <peff@peff.net> wrote:
Show 5 quoted lines
> I wonder how possible it would be to use the Git names for these utility > functions in the reftable library, and then push the common ones out > into a compat file within the reftable library. Then we could toss out > the compat file when importing the library to Git, but it could still > compile standalone.
I did this for {get,put}_u{64,32} and xstrdup. For some reason, git is missing put_u16.
Let me know if there are other functions I should look at.
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado