Re: [PATCH v16 00/14] Reftable support git-core
- From
Han-Wen Nienhuys <hanwenn@gmail.com>
- Date
- Jun 10, 2020, 06:56 UTC
- Message-ID
- <CAOw_e7ZzEyb+21QHcNGcj5A8N501-a5fF3HNL0Jq6uD8S37G6A@mail.gmail.com>
- In-Reply-To
- <xmqq7dwfhlwt.fsf@gitster.c.googlers.com>
On Wed, Jun 10, 2020 at 1:14 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> > Some issues:
> >
> > * many tests inspect .git/{logs,heads}/ directly.
> > * worktrees broken.
>
> Are these with or without GIT_TEST_REFTABLE=1?worktrees are broken with reftable, because HEAD is per-worktree ref, and I haven't decided how to handle those for reftable.
Show 7 quoted lines
> The patches (with the fix-up I saw today) applied on top of your > refs clean-up topic seems to pass the tests (without setting > GIT_TEST_REFTABLE) as the whole, but when merged at the tip of 'pu', > many tests fail (please see [*1*], for examples). I suspect that > there may be some topics in flight that add more direct access to > the .git/refs/ hierarchy, and/or there may be stupid mismerges (I'd > especially appreciate it if you can spot any).
Curious; I'll have a look.
There is also:
reftable/stack_test.c:27:7: error: incompatible pointer types
initializing 'PREC_DIR *' with an expression of type 'DIR *'
[-Werror,-Wincompatible-pointer-types]
DIR *dir = fdopendir(fd);on OSX. What is the proper dialect for reading out a directory within the git source code? opendir and fdopendir are POSIX, so I'm surprised this fails.
-- Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen