From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 26 Feb 2020 17:41:17 GMT
Subject: Re: [PATCH v6 0/5] Reftable support git-core
Message-ID: <20200226174117.GA103006@google.com>
In-Reply-To: <CAFQ2z_NQn9O3kFmHk8Cr31FY66ToU4bUdE=asHUfN++zBG+SPw@mail.gmail.com>

(+Josh Steadmon, fuzz testing specialist)
Han-Wen Nienhuys wrote:

> You have convinced me that we should go with the 4-byte identifier.
>
> How about setting version=2 and extending the header by 4 bytes (which hold
> the 4-byte identifier). The footer would also be increased in size.

SGTM.

> BTW, could we document that a reftable consisting of just a footer is a
> valid table too?

Yes, SGTM as well.

Do you have sample reftables collected somewhere that you use for
testing?  Asking since that would help us set up some fuzz tests. :)

Thanks,
Jonathan