Re: [PATCH v2 2/5] create .git/refs in files-backend.c
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Jan 28, 2020, 15:58 UTC
- Message-ID
- <CAFQ2z_PY3y4sL=W6Q3EKkB5Vc4PjfeaL0HyybfPUVA0AKxm1=A@mail.gmail.com>
- In-Reply-To
- <xmqqr1zka616.fsf@gitster-ct.c.googlers.com>
On Mon, Jan 27, 2020 at 11:28 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> > Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> > > > > Change-Id: I2fc47c89f5ec605734007ceff90321c02474aa92 > > Do we need to keep this, which is pretty much private name for the > patch that is not valid for most of the people on the list?
No, I can make do with like gitgitgadget.
Show 18 quoted lines
> > - safe_create_dir(git_path("refs"), 1);
> > - adjust_shared_perm(git_path("refs"));
> >
> > if (refs_init_db(&err))
> > die("failed to set up refs db: %s", err.buf);
> > diff --git a/refs/files-backend.c b/refs/files-backend.c
> > index 0ea66a28b6..f49b6f2ab6 100644
> > --- a/refs/files-backend.c
> > +++ b/refs/files-backend.c
> > @@ -3158,6 +3158,10 @@ static int files_init_db(struct ref_store *ref_store, struct strbuf *err)
> > files_downcast(ref_store, REF_STORE_WRITE, "init_db");
> > struct strbuf sb = STRBUF_INIT;
> >
> > + files_ref_path(refs, &sb, "refs");
> > + safe_create_dir(sb.buf, 1);
> > + // XXX adjust_shared_perm ?
>
> I am not sure what's there to wonder about with the question mark.I forgot why I put the XXX, but note that safe_create_dirs runs adjust_shared_perms implicitly.
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado