Re: [PATCH v15 00/13] Reftable support git-core
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 28, 2020, 20:15 UTC
- Message-ID
- <xmqqh7vz3jfr.fsf@gitster.c.googlers.com>
- In-Reply-To
- <pull.539.v15.git.1590695209.gitgitgadget@gmail.com>
I refrained from saying this but perhaps I should have in the early round. Next time, can you make sure the patches you are sending out apply cleanly without need for fixing whitespace errors?
This is what I got. Thanks.
$ git am -sc ./+hn13-v15-reftable
Applying: Write pseudorefs through ref backends.
Applying: Make refs_ref_exists public
Applying: Treat BISECT_HEAD as a pseudo ref
Applying: Treat CHERRY_PICK_HEAD as a pseudo ref
Applying: Treat REVERT_HEAD as a pseudo ref
Applying: Move REF_LOG_ONLY to refs-internal.h
Applying: Iterate over the "refs/" namespace in for_each_[raw]ref
Applying: Add .gitattributes for the reftable/ directory
.git/rebase-apply/patch:137: trailing whitespace.
.git/rebase-apply/patch:6784: trailing whitespace.
# Remove unittests and compatibility hacks we don't need here.
.git/rebase-apply/patch:6787: trailing whitespace.
git add reftable/*.[ch] reftable/LICENSE reftable/VERSION
.git/rebase-apply/patch:7558: indent with spaces.
left = *destLen;
.git/rebase-apply/patch:7559: indent with spaces.
*destLen = 0;
warning: squelched 16 whitespace errors
warning: 21 lines applied after fixing whitespace errors.
Applying: Add reftable library
.git/rebase-apply/patch:1865: indent with spaces.
return 1
.git/rebase-apply/patch:1876: trailing whitespace.
test_line_count = 0 output
.git/rebase-apply/patch:1892: trailing whitespace.
print_ref "refs/tags/test_tag^{}"
.git/rebase-apply/patch:1950: space before tab in indent.
git rebase source &&
.git/rebase-apply/patch:1955: new blank line at EOF.
+
warning: 4 lines applied after fixing whitespace errors.
Applying: Reftable support for git-core
Test number t0031 already taken
.git/rebase-apply/patch:385: trailing whitespace.
(cd files && GIT_DEBUG_REFS=1 test_commit message file) > files.txt &&
warning: 1 line applied after fixing whitespace errors.
Applying: Add GIT_DEBUG_REFS debugging mechanism
Test number t0033 already taken
Applying: vcxproj: adjust for the reftable changes
Applying: Add reftable testing infrastructure